Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-minimock: init at 3.0.8 #107509

Merged
merged 2 commits into from Dec 25, 2020
Merged

go-minimock: init at 3.0.8 #107509

merged 2 commits into from Dec 25, 2020

Conversation

svrana
Copy link
Member

@svrana svrana commented Dec 24, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit December 24, 2020 01:37
IvarWithoutBones
IvarWithoutBones approved these changes Dec 24, 2020
View reviewed changes
Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor nits, but otherwise LGTM 👍

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/development/tools/go-minimock/default.nix Outdated Show resolved Hide resolved
@svrana svrana force-pushed the minimock branch 2 times, most recently from 5f47604 to 7c5da8b Compare December 24, 2020 21:59
@doronbehar
Copy link
Contributor

Result of nixpkgs-review pr 107509 run on x86_64-linux 1

1 package built:
  • go-minimock

@doronbehar doronbehar merged commit de3c881 into NixOS:master Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@doronbehar doronbehar doronbehar approved these changes

@IvarWithoutBones IvarWithoutBones IvarWithoutBones approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@svrana @doronbehar @SuperSandro2000 @IvarWithoutBones