Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toybox: fix cross-compilation #107518

Merged
merged 1 commit into from Dec 25, 2020
Merged

toybox: fix cross-compilation #107518

merged 1 commit into from Dec 25, 2020

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented Dec 24, 2020

Toybox expects a native cc for producing build-time executables, such as kconfig/conf.

Tested:

  • toybox (x86_64)
  • pkgsCross.gnu32.toybox
  • pkgsCross.raspberryPi.toybox (and executables via qemu binfmt)
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-burns
toybox: fix cross-compilation
2d47a39 
Toybox expects a native `cc` for producing
build-time executables, such as kconfig/conf.
@ofborg ofborg bot requested a review from hhm0 December 24, 2020 03:51
@bjornfor bjornfor added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Dec 25, 2020
@bjornfor bjornfor merged commit 2cab487 into NixOS:master Dec 25, 2020
@r-burns r-burns deleted the toybox branch December 25, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@hhm0 hhm0 Awaiting requested review from hhm0

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r-burns @bjornfor