Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imapfilter: 2.6.16 -> 2.7.5 #107475

Merged
merged 1 commit into from Dec 24, 2020
Merged

imapfilter: 2.6.16 -> 2.7.5 #107475

merged 1 commit into from Dec 24, 2020

Conversation

doronbehar
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

matthiasbeyer
matthiasbeyer reviewed Dec 23, 2020
View reviewed changes
pkgs/applications/networking/mailreaders/imapfilter.nix

src = fetchFromGitHub {
owner = "lefcha";
repo = "imapfilter";
rev = "v${version}";
sha256 = "0f65sg6hhv6778fxwsz4hvarbm97dsb8jj0mg7a9qs273r35pqck";
sha256 = "nbVwbPkNbJz4GHhvOp+QVgiBqKA/HR34p4x3NXJB7ig=";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun: I just sent out a patch with sha256 = "0a7f85r3axwclzw1s79zl2l8222nj2gklvvq33w9qv0dz5n71dcx" to you (and others). Why is this a different hash? Seems to be another encoding, isn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I use nixUnstable so that's why I get hashes in this format. It's possible to verify I think it's the same hash, but hydra does that too anyway. Why did you send me and others that PATCH BTW?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To update the package of course.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107475 run on x86_64-linux 1

1 package built:
  • imapfilter

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107475 run on x86_64-darwin 1

1 package built:
  • imapfilter

@SuperSandro2000 SuperSandro2000 merged commit 88e20e3 into NixOS:master Dec 24, 2020
@doronbehar doronbehar deleted the pkg/imapfilter branch March 2, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doronbehar @SuperSandro2000 @matthiasbeyer