arduino: use gtk3 #107530
Merged
arduino: use gtk3 #107530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusnak
approved these changes
Dec 24, 2020
drewrisinger
suggested changes
Dec 24, 2020
| @@ -11,7 +11,8 @@ | |||
| , ncurses | |||
| , readline | |||
| , withGui ? false | |||
| , gtk2 ? null | |||
| , gtk3 ? null | |||
| , wrapGAppsHook ? null | |||
There was a problem hiding this comment.
Why is this null by default? It should be in the standard nixpkgs set.
There was a problem hiding this comment.
I followed the approach taken for the gtk3 dependency, but I'm OK with removing the default value as well
Comment on lines
33
to
34
| assert withGui -> gtk3 != null; | ||
| assert withGui -> wrapGAppsHook != null; |
There was a problem hiding this comment.
Suggested change
| assert withGui -> gtk3 != null; | |
| assert withGui -> wrapGAppsHook != null; | |
| assert withGui -> gtk3 != null && wrapGAppsHook != null; |
A one-liner is cleaner & easier to understand
|
Result of 4 packages built:
|
1 similar comment
|
Result of 4 packages built:
|
|
GUI launches and seems functional. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Tested both with a regular arduino patch and with an esp32 module
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)