Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arduino: core 1.8.12 -> 1.8.13 #107529

Merged
merged 2 commits into from Dec 25, 2020
Merged

arduino: core 1.8.12 -> 1.8.13 #107529

merged 2 commits into from Dec 25, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented Dec 24, 2020

Motivation for this change

Tested verify'ing both a regular arduino patch and an esp32 one

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from bjornfor and bergey December 24, 2020 13:23
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107529 run on x86_64-linux 1

1 package failed to build:
  • teensyduino
3 packages built:
  • arduino
  • arduino-core
  • ino

teensyduino

installing
                       Ultimate Packer for eXecutables
                          Copyright (C) 1996 - 2020
UPX 3.96        Markus Oberhumer, Laszlo Molnar & John Reiser   Jan 23rd 2020

        File size         Ratio      Format      Name
   --------------------   ------   -----------   -----------
 270962928 <-  69922796   25.81%   linux/amd64   TeensyduinoInstall.linux64

Unpacked 1 file.
Directory "/nix/store/y35c12yx0b9xj15zh5g8q7njxgdjy44f-teensyduino-1.8.13/share/arduino/" is not a supported Arduino
 Arduino versions supported: 1.8.5, 1.8.9, 1.8.11, 1.8.12

@raboof
Copy link
Member Author

raboof commented Dec 25, 2020

failed to build: teensyduino

I don't really care about teensyduino since it's unfree, but in the Christmas spirit I've updated it to 1.53. It builds now, but I haven't tested it beyond verifying it shows up as an option in the Arduino IDE now.

@doronbehar doronbehar merged commit 3d4adbd into NixOS:master Dec 25, 2020
@doronbehar
Copy link
Contributor

teensyduino is functional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@doronbehar doronbehar doronbehar approved these changes

@bjornfor bjornfor Awaiting requested review from bjornfor

@bergey bergey Awaiting requested review from bergey

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@raboof @SuperSandro2000 @doronbehar @prusnak