Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: use GST_PLUGIN_SYSTEM_PATH_1_0 instead of GST_PLUGIN_SYSTEM_PATH #107490

Merged
merged 1 commit into from Dec 24, 2020
Merged

treewide: use GST_PLUGIN_SYSTEM_PATH_1_0 instead of GST_PLUGIN_SYSTEM_PATH #107490

merged 1 commit into from Dec 24, 2020
+2 −8

Conversation

gebner
Copy link
Member

@gebner gebner commented Dec 23, 2020 •
edited

Motivation for this change

When GST_PLUGIN_SYSTEM_PATH_1_0 is set, gstreamer ignores GST_PLUGIN_SYSTEM_PATH.

For example gst-launch-1.0 used to set the GST_PLUGIN_SYSTEM_PATH variable which happened to be silently ignored if you were in a nix-shell.

I removed some of the wrapper arguments instead of changing the name; it appears that wrapGApps automatically adds the gstreamer path nowadays.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@gebner gebner changed the base branch from master to staging December 23, 2020 22:59
@gebner
treewide: use GST_PLUGIN_SYSTEM_PATH_1_0 instead of GST_PLUGIN_SYSTEM…
c9161fb 
…_PATH

When GST_PLUGIN_SYSTEM_PATH_1_0 is set, gstreamer ignores
GST_PLUGIN_SYSTEM_PATH.
@gebner gebner changed the title treewide: use GST_PLUGIN_SYSTEM_PATH_1_0 of GST_PLUGIN_SYSTEM_PATH treewide: use GST_PLUGIN_SYSTEM_PATH_1_0 instead of GST_PLUGIN_SYSTEM_PATH Dec 24, 2020
@gebner gebner merged commit e8a8d38 into NixOS:staging Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@bdimcheff bdimcheff Awaiting requested review from bdimcheff

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@gebner