tree-sitter: patch out web-ui by default, to drop emscripten #107513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tree-sitter build closure is pretty lean by default, but the optional web-ui requires emscripten to compile the web interface javascript/wasm code. This is clearly not worth the increase in build closure size, and since emscripten is broken more often than not, let’s patch it out by default. If somebody /really/ needs the web-ui, there is a `webUISupport` flag.
teto
approved these changes
Dec 24, 2020
Comment on lines
+59
to
+63
| buildInputs = | ||
| lib.optionals stdenv.isDarwin [ Security ]; | ||
| nativeBuildInputs = | ||
| [ which ] | ||
| ++ lib.optionals webUISupport [ emscripten ]; |
There was a problem hiding this comment.
Suggested change
| buildInputs = | |
| lib.optionals stdenv.isDarwin [ Security ]; | |
| nativeBuildInputs = | |
| [ which ] | |
| ++ lib.optionals webUISupport [ emscripten ]; | |
| buildInputs = lib.optionals stdenv.isDarwin [ Security ]; | |
| nativeBuildInputs = [ which ] | |
| ++ lib.optionals webUISupport [ emscripten ]; |
There was a problem hiding this comment.
The newlines were pretty much intentional. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tree-sitter build closure is pretty lean by default, but the
optional web-ui requires emscripten to compile the web interface
javascript/wasm code.
This is clearly not worth the increase in build closure size, and
since emscripten is broken more often than not, let’s patch it out by
default. If somebody /really/ needs the web-ui, there is a
webUISupportflag.Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)