Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kernel/manual-config: prevent chmod errors when there is no arch specific Makefile #107473

Closed
wants to merge 1 commit into from
Closed

kernel/manual-config: prevent chmod errors when there is no arch specific Makefile #107473

wants to merge 1 commit into from

Conversation

xaverdh
Copy link
Contributor

@xaverdh xaverdh commented Dec 23, 2020 •
edited

stab at fix #107346

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xaverdh xaverdh mentioned this pull request Dec 23, 2020
Closed
layus
layus approved these changes Dec 23, 2020
View reviewed changes
Copy link
Member

@layus layus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart but trivial. LGTM

@xaverdh xaverdh marked this pull request as ready for review December 23, 2020 20:12
@xaverdh
Copy link
Contributor Author

xaverdh commented Dec 24, 2020

ah the 501+ rebuild is because manual-config.nix is used by all kernels?
Should I target staging instead of master?

@Atemu
Copy link
Member

Atemu commented Dec 24, 2020

Yeah, IMO an improvement with no direct benefit for the user that causes a significant amount of rebuilds should go to staging.

This way it's bundled with all the other rebuilds that would have to happen anyways.

@xaverdh xaverdh mentioned this pull request Dec 24, 2020
Merged
10 tasks
@xaverdh
Copy link
Contributor Author

xaverdh commented Dec 24, 2020

replaced by #107525 (against staging)

@xaverdh xaverdh closed this Dec 24, 2020
@Atemu
Copy link
Member

Atemu commented Dec 24, 2020

For future reference, you can just change the base the PR is supposed to be merged to using "Edit" button in the top right.

@xaverdh
Copy link
Contributor Author

xaverdh commented Dec 24, 2020

For future reference, you can just change the base the PR is supposed to be merged to using "Edit" button in the top right.

I have had issues with that in the past where the github messed up the rebase and the whole world was pinged for review..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layus layus layus approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@teto teto Awaiting requested review from teto

@Atemu Atemu Awaiting requested review from Atemu

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nixos-rebuild fails when trying to build a custom kernel as per wiki instructions
3 participants
@xaverdh @Atemu @layus