Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nixops check: Ignore non-existing home.mount #1427

Closed
wants to merge 2 commits into from
Closed

Fix nixops check: Ignore non-existing home.mount #1427

wants to merge 2 commits into from

Conversation

roberth
Copy link
Member

@roberth roberth commented Dec 24, 2020

Exactly like tmp.mount.

quote

                # Currently in systemd, failed mounts enter the
                # "inactive" rather than "failed" state.  So check for
                # that.  Hack: ignore special filesystems like
                # /sys/kernel/config and /tmp. Systemd tries to mount these
                # even when they don't exist.

@roberth roberth force-pushed the fix-nixops-check-home-mount branch 2 times, most recently from ad2ce11 to 76fd586 Compare December 30, 2020 16:57
@roberth roberth changed the title nixops check: Ignore non-existing home.mount Fix nixops check: Ignore non-existing home.mount Jan 18, 2021
@roberth
Copy link
Member Author

roberth commented Jan 18, 2021

@grahamc could you review this?

@adisbladis adisbladis mentioned this pull request Feb 3, 2021
Merged
adisbladis added a commit that referenced this pull request Feb 3, 2021
@adisbladis
Merge pull request #1435 from NixOS/fix-nixops-check-home-mount
1ed5a09 
 Fix nixops check: Ignore non-existing home.mount (rebased #1427)
@adisbladis
Copy link
Member

Rebased and merged in #1435

@adisbladis adisbladis closed this Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roberth @adisbladis