Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast variants fully for libc++10 #4397

Merged
merged 3 commits into from Dec 30, 2020
Merged

Cast variants fully for libc++10 #4397

merged 3 commits into from Dec 30, 2020

Conversation

matthewbauer
Copy link
Member

libc++10 seems to be stricter on what it allows in variant conversion.
I'm not sure what the rules are here, but this is the minimal change
needed to get through the compilation errors.

@matthewbauer
Cast variants fully for libc++10
d487046 
libc++10 seems to be stricter on what it allows in variant conversion.
I'm not sure what the rules are here, but this is the minimal change
needed to get through the compilation errors.
@matthewbauer matthewbauer mentioned this pull request Dec 24, 2020
Closed
@r-burns
Copy link
Contributor

r-burns commented Dec 24, 2020

This fixes nixUnstable under gcc10Stdenv for me 👍

@edolstra
Copy link
Member

Looks like this breaks the build with GCC 9:

src/libexpr/eval-cache.cc: In member function 'nix::Value& nix::eval_cache::AttrCursor::forceValue()':
src/libexpr/eval-cache.cc:396:25: error: invalid use of non-static member function 'nix::ValueType nix::Value::type() const'
  396 |         else if (v.type == nPath)
      |                  ~~~~~~~^~~~~~~~

edolstra
edolstra reviewed Dec 28, 2020
View reviewed changes
src/libexpr/eval-cache.cc Outdated Show resolved Hide resolved
@edolstra edolstra merged commit bff706e into NixOS:master Dec 30, 2020
@ldesgoui ldesgoui mentioned this pull request Aug 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra edolstra is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthewbauer @r-burns @edolstra