Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zig: 0.6.0 -> 0.7.1 #107535

Merged
merged 1 commit into from Dec 25, 2020
Merged

zig: 0.6.0 -> 0.7.1 #107535

merged 1 commit into from Dec 25, 2020

Conversation

miikka
Copy link
Contributor

@miikka miikka commented Dec 24, 2020

Motivation for this change

Version bump - release notes: 0.7.0, 0.7.1.

I had to edit the check command a bit to make it work as the cache directory handling seems to have changed since 0.6.0. I'm a Nix(OS) newbie, so I'm not entirely sure what I'm doing but the change seemed straightforward enough.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from andrewrk December 24, 2020 15:14
@sternenseemann
Copy link
Member

Result of nixpkgs-review pr 107535 1

1 package built:
  • zig

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107535 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • zig

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107535 run on x86_64-linux 1

1 package built:
  • zig

@SuperSandro2000 SuperSandro2000 merged commit f031781 into NixOS:master Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewrk andrewrk Awaiting requested review from andrewrk

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miikka @sternenseemann @SuperSandro2000 @Janik-Haag