[selectors] Improve :focus-visible tests #27000
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change "auto" outline-style by "solid". These tests were using "outline-style: auto" but then set an outline-color. Some browsers like Firefox ignore the outline-color when rendering the auto style, which is allowed according to the spec: https://drafts.csswg.org/css-ui/#typedef-outline-line-style * Now we have one test per element, so we have more detailed PASS/FAIL information. We also check that all test conditions (outline and background colors) are right. * focus-visible-004.html actually set "appearance: none". So elements that are hidden now and not focusable (radio button and checkbox) are removed. * focus-visible-007.html is not modified as it has more problems (see crbug.com/976438). Change-Id: I616aa23ec623391b521d4d4eda90e914496bf074
wpt-pr-bot
approved these changes
Dec 23, 2020
|
The Chromium CL has been abandoned as this was done in #27032 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests were using "outline-style: auto" but then
set an outline-color. Some browsers like Firefox ignore the
outline-color when rendering the auto style, which is allowed
according to the spec:
https://drafts.csswg.org/css-ui/#typedef-outline-line-style
PASS/FAIL information. We also check that all test conditions
(outline and background colors) are right.
So elements that are hidden now and not focusable
(radio button and checkbox) are removed.
(see crbug.com/976438).
Change-Id: I616aa23ec623391b521d4d4eda90e914496bf074
Reviewed-on: https://chromium-review.googlesource.com/2596079
WPT-Export-Revision: 3ab57cd9169628df7d19a02155eb7d6b5a048ddf