Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pe-parse: init at 1.2.0 #107506

Merged
merged 1 commit into from Jan 13, 2021
Merged

pe-parse: init at 1.2.0 #107506

merged 1 commit into from Jan 13, 2021

Conversation

arcz
Copy link
Member

@arcz arcz commented Dec 24, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@arcz arcz force-pushed the pe-parse branch 2 times, most recently from 0710dcd to dfd1662 Compare December 24, 2020 00:47
r-burns
r-burns reviewed Dec 24, 2020
View reviewed changes
pkgs/development/libraries/pe-parse/default.nix
};

nativeBuildInputs = [ cmake ];

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be a candidate for multiple outputs if you wish to reduce dependers' closure size

  outputs = [ "out" "dev" "bin" ];

  postInstall = ''
    moveToOutput bin $bin
  '';

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some trouble building another library this way. Maybe I'll leave the single output for now as it's not big and refactor that later if needed.

pkgs/development/libraries/pe-parse/default.nix Outdated Show resolved Hide resolved
r-burns
r-burns approved these changes Dec 24, 2020
View reviewed changes
Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 107506 run on x86_64-linux 1

1 package built:
  • pe-parse

@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 107506 1

1 package built:
  • pe-parse

thiagokokada
thiagokokada reviewed Dec 30, 2020
View reviewed changes
Copy link
Contributor

@thiagokokada thiagokokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a random Windows binary, seems to work.

However I think leaving this in pkgs/development/libraries/ kinda strange. Wouldn't it make more sense to put this in pkgs/development/tools/? 🤔

@arcz
Copy link
Member Author

arcz commented Jan 2, 2021

pe-parse is a library, the dump-pe program is rather an extra thing

cole-h
cole-h requested changes Jan 13, 2021
View reviewed changes
pkgs/development/libraries/pe-parse/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/pe-parse/default.nix Outdated Show resolved Hide resolved
cole-h
cole-h approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM.

Result of nixpkgs-review pr 107506 run on x86_64-linux 1

1 package built:
  • pe-parse

@cole-h cole-h merged commit 73db866 into NixOS:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@cole-h cole-h cole-h approved these changes

@r-burns r-burns r-burns approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arcz @thiagokokada @cole-h @r-burns