Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

erlang: make systemdSupport overridable #107500

Merged
merged 1 commit into from Jan 2, 2021
Merged

erlang: make systemdSupport overridable #107500

merged 1 commit into from Jan 2, 2021

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 23, 2020 •
edited

Motivation for this change

systemd is a pretty large dependency, and it would be nice to have a "minimal" erlang closure for some scenarios like docker images.

cc @NobbZ

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
$ nix path-info -Sh ./result # master
/nix/store/787qlzbhx2zr8mdpw7w3mjq2yid5wmb1-erlang-22.3	 415.9M
$ nix path-info -Sh ./result # This PR
/nix/store/s38hj41hxivrghypgrvr3fiz9krvicdy-erlang-22.3	 305.9M

@jonringer
Copy link
Contributor Author

0 rebuilds

@jonringer jonringer merged commit 30f4aed into NixOS:master Jan 2, 2021
@jonringer jonringer deleted the erlang-systemd branch January 2, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
6.topic: erlang 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @SuperSandro2000