Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.jsonfield: init at 3.1.0 #107536

Merged
merged 1 commit into from Dec 29, 2020
Merged

python3Packages.jsonfield: init at 3.1.0 #107536

merged 1 commit into from Dec 29, 2020

Conversation

MrMebelMan
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107536 run on x86_64-darwin 1

3 packages failed to build:
  • python37Packages.jsonfield
  • python38Packages.jsonfield
  • python39Packages.jsonfield
  File "/nix/store/kq4r0xn7ia8alvv0v1bp0dac0mvnjddf-python3.8-pluggy-0.13.1/lib/python3.8/site-packages/pluggy/callers.py", line 208, in _multicall
    return outcome.get_result()
  File "/nix/store/kq4r0xn7ia8alvv0v1bp0dac0mvnjddf-python3.8-pluggy-0.13.1/lib/python3.8/site-packages/pluggy/callers.py", line 80, in get_result
    raise ex[1].with_traceback(ex[2])
  File "/nix/store/kq4r0xn7ia8alvv0v1bp0dac0mvnjddf-python3.8-pluggy-0.13.1/lib/python3.8/site-packages/pluggy/callers.py", line 187, in _multicall
    res = hook_impl.function(*args)
  File "/nix/store/4qm4lh6iv2pkrsh8lmwkjjvqvr3ivv84-python3.8-pytest-django-4.1.0/lib/python3.8/site-packages/pytest_django/plugin.py", line 320, in pytest_load_initial_conftests
    dj_settings.DATABASES
  File "/nix/store/72qx63lh6h0l56izan1lvc4px0mqrsdp-python3.8-Django-2.2.17/lib/python3.8/site-packages/django/conf/__init__.py", line 79, in __getattr__
    self._setup(name)
  File "/nix/store/72qx63lh6h0l56izan1lvc4px0mqrsdp-python3.8-Django-2.2.17/lib/python3.8/site-packages/django/conf/__init__.py", line 66, in _setup
    self._wrapped = Settings(settings_module)
  File "/nix/store/72qx63lh6h0l56izan1lvc4px0mqrsdp-python3.8-Django-2.2.17/lib/python3.8/site-packages/django/conf/__init__.py", line 188, in __init__
    if zoneinfo_root.exists() and not zone_info_file.exists():
  File "/nix/store/v3qi2n1cb9bj8h3076p3rz5fg0kpzz53-python3-3.8.6/lib/python3.8/pathlib.py", line 1391, in exists
    self.stat()
  File "/nix/store/v3qi2n1cb9bj8h3076p3rz5fg0kpzz53-python3-3.8.6/lib/python3.8/pathlib.py", line 1197, in stat
    return self._accessor.stat(self)
PermissionError: [Errno 1] Operation not permitted: '/usr/share/zoneinfo'

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107536 run on x86_64-linux 1

3 packages built:
  • python37Packages.jsonfield
  • python38Packages.jsonfield
  • python39Packages.jsonfield

@SuperSandro2000
Copy link
Member

Can you squash the commit into one init commit?

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107536 run on x86_64-linux 1

3 packages built:
  • python37Packages.jsonfield
  • python38Packages.jsonfield
  • python39Packages.jsonfield

@fabaff
Copy link
Member

fabaff commented Dec 28, 2020

Result of nixpkgs-review pr 107536 run on x86_64-linux 1

3 packages built:
  • python37Packages.jsonfield
  • python38Packages.jsonfield
  • python39Packages.jsonfield

@MrMebelMan
Copy link
Contributor Author

Reordered jsondiff and jsonfield and squashed into init commit

@prusnak prusnak merged commit 534b82f into NixOS:master Dec 29, 2020
@MrMebelMan MrMebelMan deleted the init/jsonfield_3_1_0 branch December 30, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MrMebelMan @SuperSandro2000 @fabaff @prusnak