Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neochat: init at 1.0 #107496

Merged
merged 2 commits into from Dec 25, 2020
Merged

neochat: init at 1.0 #107496

merged 2 commits into from Dec 25, 2020

Conversation

mjlbach
Copy link
Contributor

@mjlbach mjlbach commented Dec 23, 2020 •
edited

Motivation for this change

Neochat is a fork/continuation of spectral and an official KDE project.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mjlbach mjlbach force-pushed the init_neochat branch 3 times, most recently from 1829af5 to dd40c8f Compare December 23, 2020 23:04
@lovesegfault
Copy link
Member

Is there a PR for packaging kquickimageeditor that can be cross-linked? Also, this should be marked as a draft in the meantime.

@lovesegfault lovesegfault marked this pull request as draft December 24, 2020 04:19
@mjlbach
Copy link
Contributor Author

mjlbach commented Dec 24, 2020 •
edited

No PR yet. I was working on one in the process of this and have something locally that I will try to get finished up soon. Thanks for marking it as a draft (I forgot to do that). I was also going down the rabbit hole of darwin support, and it looks like this will be blocked until at least phonon support is added to darwin (dependency of knotifications).

@lovesegfault
Copy link
Member

No PR yet. I was working on one in the process of this and have something locally that I will try to get finished up soon. Thanks for marking it as a draft (I forgot to do that).

Awesome, feel free to ping me whenever that PR goes up and I'm happy to review/test/merge :)

@mjlbach mjlbach force-pushed the init_neochat branch 2 times, most recently from 36f60f3 to be23d75 Compare December 24, 2020 05:22
@mjlbach
Copy link
Contributor Author

mjlbach commented Dec 24, 2020 •
edited

@lovesegfault I just pushed everything, I put it all into this PR since the only thing depending on that library is neochat. Seems to work, but not sure if I missed anything. The icons are missing, and there should be darkmode support (but I can't seem to get it working on non-nixos systems), but not sure if these are neochat bugs.

I get this error on plasma on nixos on nixpgs-unstableCannot mix incompatible Qt library (5.15.0) with this library (5.15.2) I think this is due to the version bump to plasma/5.15.2 recently as setting QT_PLUGIN_PATH to "" resolves the problem.

@mjlbach mjlbach marked this pull request as ready for review December 24, 2020 05:24
@mjlbach mjlbach force-pushed the init_neochat branch 2 times, most recently from 3369256 to d5b5643 Compare December 24, 2020 05:28
@colemickens
Copy link
Member

Did you already try mkDerivation, I have had this suggested to me in the past per the manual: https://nixos.org/manual/nixpkgs/stable/#sec-language-qt but maybe you already tried and then resorted to doing it manually?

@mjlbach
Copy link
Contributor Author

mjlbach commented Dec 24, 2020 •
edited

I've updated it to use mkDerivation. I originally used the one from stdenv copying spectral's derivation, I don't think it makes much of a difference. FWIW everything works-ish. The icons are a known issue upstream https://invent.kde.org/network/neochat/-/issues/135

The QT_PLUGIN _PATH situation seems to be a known issue with QT packaging and will be resolved by the time this hits nixpkgs-unstable.

I also copied all the old dependencies, I didn't rigorously test to make sure they were all needed.

lovesegfault
lovesegfault approved these changes Dec 25, 2020
View reviewed changes
Copy link
Member

@lovesegfault lovesegfault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lovesegfault lovesegfault merged commit 29f7ba6 into NixOS:master Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesegfault lovesegfault lovesegfault approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mjlbach @lovesegfault @colemickens