Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python37Packages.hmmlearn: unbreak tests #107521

Merged
merged 1 commit into from Dec 25, 2020
Merged

python37Packages.hmmlearn: unbreak tests #107521

merged 1 commit into from Dec 25, 2020

Conversation

rmcgibbo
Copy link
Contributor

Motivation for this change

I saw that this was broken on hydra. I aligned the tests a little bit better with how they're done upstream, so that we're not running some broken doctests that upstream doesn't appear to use

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from abbradar December 24, 2020 05:13
@fabaff
Copy link
Member

fabaff commented Dec 24, 2020

Result of nixpkgs-review pr 107521 run on x86_64-linux 1

3 packages built:
  • python37Packages.hmmlearn
  • python38Packages.hmmlearn
  • python39Packages.hmmlearn

fabaff
fabaff approved these changes Dec 24, 2020
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107521 run on x86_64-darwin 1

3 packages built:
  • python37Packages.hmmlearn
  • python38Packages.hmmlearn
  • python39Packages.hmmlearn

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107521 run on x86_64-linux 1

3 packages built:
  • python37Packages.hmmlearn
  • python38Packages.hmmlearn
  • python39Packages.hmmlearn

@SuperSandro2000 SuperSandro2000 merged commit 107c9d6 into NixOS:master Dec 25, 2020
@rmcgibbo rmcgibbo deleted the hmmlearn branch December 25, 2020 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rmcgibbo @fabaff @SuperSandro2000