Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpuset: 1.5.8 -> 1.6 #107512

Merged
merged 1 commit into from Dec 27, 2020
Merged

cpuset: 1.5.8 -> 1.6 #107512

merged 1 commit into from Dec 27, 2020

Conversation

thiagokokada
Copy link
Contributor

@thiagokokada thiagokokada commented Dec 24, 2020 •
edited

Motivation for this change

Switch from wykurz to lpechacek fork, so we can use Python 3 instead of Python 2. However, Python 2 should still works.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from wykurz December 24, 2020 02:09
@thiagokokada
Copy link
Contributor Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 24, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 24, 2020

@glittershark please review.

@thiagokokada
Copy link
Contributor Author

Result of nixpkgs-review pr 107512 1

1 package built:
  • cpuset

thiagokokada
thiagokokada commented Dec 24, 2020
View reviewed changes
pkgs/os-specific/linux/cpuset/default.nix

propagatedBuildInputs = [ ];
propagatedBuildInputs = with pythonPackages; [
configparser
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary for Python 3, but if we want this package to continue to work with Python 2 this needs to be included.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package is usually used as a CLI tool so I don't think it's hugely important to keep the Python 2 support (especially that we're not testing it?), although I don't see much harm in it either.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, me too, I am ok either way.

wykurz
wykurz approved these changes Dec 24, 2020
View reviewed changes
pkgs/os-specific/linux/cpuset/default.nix

propagatedBuildInputs = [ ];
propagatedBuildInputs = with pythonPackages; [
configparser
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package is usually used as a CLI tool so I don't think it's hugely important to keep the Python 2 support (especially that we're not testing it?), although I don't see much harm in it either.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107512 run on x86_64-darwin 1

1 package built:
  • cpuset

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107512 run on x86_64-linux 1

1 package built:
  • cpuset

@ofborg ofborg bot requested a review from wykurz December 25, 2020 22:30
glittershark
glittershark reviewed Dec 26, 2020
View reviewed changes
pkgs/os-specific/linux/cpuset/default.nix Outdated
];

# https://github.com/lpechacek/cpuset/pull/36
patches = fetchpatch {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't patches usually a list?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I put fetchpatch inside a list it returns an error.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, ok then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use this style:

nixpkgs/pkgs/development/tools/phantomjs2/default.nix

Line 38 in e7fe577

patches = [

@thiagokokada
cpuset: 1.5.8 -> 1.6
563ce87 
Switch from wykurz to lpechacek fork, so we can use Python 3 instead of
Python 2. However, Python 2 should still works.

Also, fix this issue since it is easy:
SUSE/cpuset#38
@glittershark
Copy link
Member

Result of nixpkgs-review pr 107512 1

1 package built:
  • cpuset

@glittershark
Copy link
Member

tested the result, appears to work

@glittershark
Copy link
Member

/status needs_merger

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107512 run on x86_64-linux 1

1 package built:
  • cpuset

@SuperSandro2000 SuperSandro2000 merged commit 09794ef into NixOS:master Dec 27, 2020
@thiagokokada thiagokokada deleted the bump-cpuset branch January 4, 2021 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@glittershark glittershark glittershark approved these changes

@wykurz wykurz Awaiting requested review from wykurz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer marvin needs_merger
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thiagokokada @SuperSandro2000 @glittershark @wykurz