Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve nix.py #254

Merged
merged 5 commits into from Dec 18, 2020
Merged

Improve nix.py #254

merged 5 commits into from Dec 18, 2020

Conversation

ncfavier
Copy link
Member

Adds escaping of \ and " inside double-quoted strings (see system.name), and fixes indentation for double-single-quoted strings and literalExamples (see services.snapper.configs).

@ncfavier ncfavier requested a review from garbas December 17, 2020 13:59
@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2020 •
edited

🚀 Deployed on https://5fdc9641127ec7f958ecfa8a--nixos-search.netlify.app

@garbas
Copy link
Member

garbas commented Dec 17, 2020

@ncfavier can you add some tests for this use cases? Also if you can point to me which options are being fixed by this?

@ncfavier
Copy link
Member Author

ncfavier commented Dec 17, 2020 •
edited

I did: system.name and services.snapper.configs. Where would you like me to add tests?

(Well system.name is still broken because it should use defaultText instead of default, but at least it demonstrates the string escaping logic.)

garbas
garbas approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@garbas garbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ncfavier no worries. I've merged the master and added the tests.

I will run the import manually in few minutes.

@ncfavier
Copy link
Member Author

Looks good to me!

@garbas garbas merged commit aea6789 into master Dec 18, 2020
@garbas garbas deleted the fix-nix-py branch December 18, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garbas garbas garbas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ncfavier @garbas