Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

joycond: init at unstable-2021-03-27 #107099

Merged
merged 1 commit into from Apr 5, 2021
Merged

joycond: init at unstable-2021-03-27 #107099

merged 1 commit into from Apr 5, 2021

Conversation

IvarWithoutBones
Copy link
Member

@IvarWithoutBones IvarWithoutBones commented Dec 17, 2020 •
edited

Motivation for this change

Saw nintendo-hid got merged with Linux 5.10, and thought this would be a nice addition to that.

Latest release tag is pretty old, so I've just fetched the last commit.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@WolfangAukang
Copy link
Contributor

Result of nixpkgs-review pr 107099 run on x86_64-linux 1

1 package built:
  • joycond

@jakobrs
Copy link
Contributor

jakobrs commented Mar 15, 2021

You also probably want to patch the joycond.service file since it hardcodes the path to the joycond executable.

SuperSandro2000
SuperSandro2000 requested changes Mar 22, 2021
View reviewed changes
pkgs/os-specific/linux/joycond/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/joycond/default.nix Outdated Show resolved Hide resolved
@IvarWithoutBones
Copy link
Member Author

You also probably want to patch the joycond.service file since it hardcodes the path to the joycond executable.

I am already doing this though, see this: https://github.com/NixOS/nixpkgs/blob/e47e2659400b69330123a080f876038f9e8a09e6/pkgs/os-specific/linux/joycond/default.nix#L26

@IvarWithoutBones IvarWithoutBones changed the title joycond: init at 2020-11-05 joycond: init at unstable-2021-03-27 Apr 4, 2021
@jakobrs
Copy link
Contributor

jakobrs commented Apr 4, 2021

You also probably want to patch the joycond.service file since it hardcodes the path to the joycond executable.

I am already doing this though, see this:

https://github.com/NixOS/nixpkgs/blob/e47e2659400b69330123a080f876038f9e8a09e6/pkgs/os-specific/linux/joycond/default.nix#L26

You're right, I'm sorry, I must've missed this.

jakobrs
jakobrs suggested changes Apr 4, 2021
View reviewed changes
Copy link
Contributor

@jakobrs jakobrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason CI is failing is because pkgconfig should be pkg-config. If you fix this I'm fairly sure it'll pass.

pkgs/os-specific/linux/joycond/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/joycond/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 merged commit 56b8c36 into NixOS:master Apr 5, 2021
@IvarWithoutBones IvarWithoutBones deleted the joycond-init branch April 5, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@jakobrs jakobrs jakobrs requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@IvarWithoutBones @WolfangAukang @jakobrs @SuperSandro2000