Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCPITMCTransport: reading a reply via multiple ReadRawData() calls fails #386

Open
azonenberg opened this issue Dec 17, 2020 · 4 comments
Open
Labels
bug Something isn't working driver Hardware drivers
Milestone

Comments

@azonenberg
Copy link
Collaborator

The current implementation will break any logic that uses multiple ReadRawData() calls to read a variable length SCPI response (length in one call then data in the next). At least Tek MSO6 is affected.

@tomverbeure I believe this was your code originally?

@azonenberg azonenberg added bug Something isn't working driver Hardware drivers labels Dec 17, 2020
@tomverbeure
Copy link
Contributor

In general, my Siglent scope on USBTMC is very broken, requiring a power cycle of the scope as soon as something went wrong, so I wasn't able to do a whole lot of debugging on this.

That said, if this particular function is giving you issues on the Tek scope, chances are that you will have the same issue when using the Lxi driver, because most of the code is a copy.

@azonenberg
Copy link
Collaborator Author

Interestingly no. I get buffer exhausted errors with USBTMC that render the scope unusable, while it (mostly) works via raw TCP or LXI.

@tomverbeure
Copy link
Contributor

Can you change this line to #if 1 and see what happens?

This is assuming that your Linux kernel has rev2 of the USBTMC driver installed.

@azonenberg azonenberg added this to the v0.1 milestone May 1, 2021
@azonenberg azonenberg modified the milestones: v0.1, v0.2 May 12, 2021
@azonenberg
Copy link
Collaborator Author

Moved to v0.2 as not currently critical and I don't have access to an MSO64 to test with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working driver Hardware drivers
Projects
None yet
Development

No branches or pull requests

2 participants