Skip to content

niv: fixes #106906 #107096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2020
Merged

niv: fixes #106906 #107096

merged 1 commit into from
Dec 17, 2020
+1 −1

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Dec 17, 2020

Motivation for this change

I merged this PR too soon and forgot to check that the output was still
containing the binary.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@zimbatm
Copy link
Member Author

zimbatm commented Dec 17, 2020

Result of nixpkgs-review pr 107096 run on x86_64-linux 1

@zimbatm zimbatm mentioned this pull request Dec 17, 2020
Merged
10 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 17, 2020
@nmattia nmattia mentioned this pull request Dec 17, 2020
Closed
10 tasks
@zimbatm
niv: fixes NixOS#106906
c14da26 
I merged this PR too soon and forgot to check that the output was still
containing the binary.
@zimbatm
Copy link
Member Author

zimbatm commented Dec 17, 2020

ok, I triple-checked that the output contains the bin this time.

@zimbatm zimbatm merged commit c040b91 into NixOS:master Dec 17, 2020
@zimbatm zimbatm deleted the niv-static-fix branch December 17, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir

@nmattia nmattia

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zimbatm @andir @nmattia