Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.ciscomobilityexpress: init at 0.3.9 #107095

Merged
merged 2 commits into from Dec 18, 2020
Merged

pythonPackages.ciscomobilityexpress: init at 0.3.9 #107095

merged 2 commits into from Dec 18, 2020

Conversation

uvNikita
Copy link
Contributor

Motivation for this change

Fixes import module error when using cisco_mobility_express home assistant component:

nixpkgs/pkgs/servers/home-assistant/component-packages.nix

Line 116 in b83e5b8

"cisco_mobility_express" = ps: with ps; [ ]; # missing inputs: ciscomobilityexpress

@mweinelt

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

mweinelt
mweinelt requested changes Dec 17, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

One nit: The component-packages update is a change to the home-assistant package, and should therefore be in a separate commit home-assistant: update component-packages.

@uvNikita
Copy link
Contributor Author

@mweinelt thanks for the review!

I added commit that updates component-packages.nix file.

@mweinelt
Copy link
Member

Result of nixpkgs-review pr 107095 run on x86_64-linux 1

3 packages built:
  • python37Packages.ciscomobilityexpress
  • python38Packages.ciscomobilityexpress
  • python39Packages.ciscomobilityexpress

@mweinelt mweinelt merged commit 7c2d133 into NixOS:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@uvNikita @mweinelt