[staging] rust: cleanup, use correct llvm version #106886

lblasc · 2020-12-14T08:51:35Z

Motivation for this change

I've noticed rustc 1.48 uses LLVM 10 while version 11 is set in all-packages:

$ rustc -vV
rustc 1.48.0
binary: rustc
commit-hash: unknown
commit-date: unknown
host: x86_64-unknown-linux-gnu
release: 1.48.0
LLVM version: 10.0

This change properly propagates correct runtime LLVM version. I've also removed bootstrap override
for clang based stdenv, which should be unnecessary, I didn't test it.

Things done

zowoq · 2020-12-14T12:06:31Z

I've also removed bootstrap override for clang based stdenv, which should be unnecessary, I didn't test it.

Fails to build on darwin.

  = note: dyld: Symbol not found: __ZN4llvm14FoldingSetBase6anchorEv
            Referenced from: /nix/store/xkwl96h8ls93ggcm3xm02qij7vm7bww5-clang-7.1.0/bin/clang
            Expected in: /nix/store/4y4l10w5xclx0w27ddixnxcjzszw380h-rustc-bootstrap-1.47.0/lib/libLLVM.dylib
           in /nix/store/xkwl96h8ls93ggcm3xm02qij7vm7bww5-clang-7.1.0/bin/clang

lblasc · 2020-12-14T15:18:26Z

@zowoq Thx for testing, didn't have any darwin machine to test on.

I've reverted those changes but in a way that is more obvious what is used for, hope it is ok.

Mic92 · 2020-12-15T10:21:09Z

Builds thunderbird on Linux. Can someone check building rustc on macOS? cc @dasJ

dasJ · 2020-12-15T11:35:17Z

Result of nixpkgs-review pr 106886 1

220 packages marked as broken and skipped:

agdaPackages.iowa-stdlib
almanah
aravis
asymptote
atom
atom-beta
autotrace
bluefish
btrbk
connman_dmenu
contrast
couchdb3
dasher
deluge
deluge-2_x
devede
direwolf
equilux-theme
espanso
faba-icon-theme
falkon
far2l
fgallery
firefox-esr-78-unwrapped
firefox-unwrapped
firefoxPackages.firefox
firefoxPackages.firefox-esr-78
font-manager
fontpreview
foxtrotgps
fractal
frescobaldi
gammastep
gcolor3
gimpPlugins.ufraw
gitAndTools.git-dit
glabels
gmic-qt-krita
gnome-podcasts
gnome-recipes
gnome3.eog
gnome3.gedit
gnome3.nautilus-python
gnuradio
gnuradio3_7
gobby5
gscan2pdf
gspeech
gtkd
haskellPackages.gi-ibus
haskellPackages.gnome-keyring
hyena
ibus-engines.libthai
imv
intecture-cli
invoice2data
jabref
kicad-small
kicad-unstable-small
kodi-cli
krunner-pass
latte-dock
libsForQt5.alkimia
libsForQt5.packagekit-qt
libsForQt512.alkimia
libsForQt512.packagekit-qt
libsForQt514.alkimia
libsForQt514.packagekit-qt
libsForQt515.alkimia
libsForQt515.packagekit-qt
lilypond-unstable
liquidsoap
lounge-gtk-theme
lumina.lumina
maia-icon-theme
mail-notification
malcontent
malcontent-ui
marwaita
marwaita-manjaro
marwaita-peppermint
marwaita-pop_os
marwaita-ubuntu
matcha-gtk-theme
mate.atril
mate.caja
mate.caja-extensions
mate.engrampa
mate.eom
mate.marco
mate.mate-control-center
mate.mate-icon-theme-faenza
mate.mate-indicator-applet
mate.mate-media
mate.mate-netbook
mate.mate-notification-daemon
mate.mate-panel
mate.mate-polkit
mate.mate-power-manager
mate.mate-screensaver
mate.mate-session-manager
mate.mate-settings-daemon
mate.mate-system-monitor
mate.mate-terminal
mate.mate-themes
mate.mate-user-guide
mate.mate-user-share
mate.mate-utils
mate.pluma
mate.python-caja
materia-theme
mavproxy
mikutter
mojave-gtk-theme
mopidy-musicbox-webclient
networkmanager_dmenu
newsflash
odpdown
onboard
openshot-qt
packagekit
pcsx2
pdfmod
picard
pipr
plano-theme
poedit
polkit
pond
pop-icon-theme
portmod
pympress
python37Packages.baselines
python37Packages.gym
python37Packages.kicad
python37Packages.loo-py
python37Packages.paperwork-backend
python37Packages.paperwork-shell
python37Packages.pyglet
python37Packages.pyocr
python37Packages.python-vlc
python37Packages.pytmx
python37Packages.rl-coach
python37Packages.roboschool
python37Packages.wxPython_4_0
python37Packages.wxPython_4_1
python38Packages.gym
python38Packages.kicad
python38Packages.loo-py
python38Packages.paperwork-backend
python38Packages.paperwork-shell
python38Packages.pyglet
python38Packages.pyocr
python38Packages.python-vlc
python38Packages.pytmx
python38Packages.roboschool
python38Packages.wxPython_4_0
python38Packages.wxPython_4_1
python39Packages.gym
python39Packages.kicad
python39Packages.loo-py
python39Packages.paperwork-backend
python39Packages.paperwork-shell
python39Packages.pyglet
python39Packages.pyocr
python39Packages.python-vlc
python39Packages.pytmx
python39Packages.roboschool
python39Packages.wxPython_4_0
python39Packages.wxPython_4_1
qogir-theme
quassel
quasselClient
racket
radiotray-ng
railcar
rdedup
redshift
redshift-wlr
rofi-menugen
run-scaled
rustracerd
safeeyes
sandboxfs
setzer
shutter
sierra-gtk-theme
sit
skeu
spek
split2flac
strongswanNM
sublime-music
surf
sway-contrib.grimshot
syncthing-gtk
termite
termite-unwrapped
tev
udiskie
ufraw
uget
uim
venta
virt-manager-qt
vuze
waybar
xfce.xfce4-hardware-monitor-plugin
xfce.xfce4-sensors-plugin
xfce.xfce4-weather-plugin
xfce.xfce4-windowck-plugin
xfce.xfce4_hardware_monitor_plugin
xfce.xfce4_sensors_plugin
xfce.xfce4_weather_plugin
xfce.xfce4_windowck_plugin
xidlehook
xulrunner
yaxg
zim
zoneminder

518 packages failed to build:

aerc
afew
agdaPackages.agda-categories
agdaPackages.agda-prelude
agdaPackages.cubical
agdaPackages.functional-linear-algebra
agdaPackages.generic
agdaPackages.standard-library
alacritty
amber
amp
angle-grinder
arandr
ario
as-tree
asciidoc-full
asciidoc-full-with-plugins
asciinema-scenario
asuka
async
auctex
awf
b3sum
balsa
bandwhich
bat
bat-extras.batdiff
bat-extras.batgrep
bat-extras.batman
bat-extras.batwatch
bat-extras.prettybat
bingrep
bitwarden_rs (bitwarden_rs-sqlite)
bitwarden_rs-mysql
bitwarden_rs-postgresql
bleachbit
blockhash
boringtun
bottom
broot
bukubrow
cargo
cargo-about
cargo-asm
cargo-audit
cargo-bloat
cargo-c
cargo-cache
cargo-crev
cargo-deb
cargo-deny
cargo-deps
cargo-edit
cargo-embed
cargo-expand
cargo-flamegraph
cargo-flash
cargo-fund
cargo-fuzz
cargo-geiger
cargo-generate
cargo-graph
cargo-inspect
cargo-insta
cargo-kcov
cargo-license
cargo-make
cargo-outdated
cargo-raze
cargo-release
cargo-sweep
cargo-sync-readme
cargo-udeps
cargo-update
cargo-watch
cargo-web
cargo-xbuild
cask
castor
cataract
cataract-unstable
ccache
ccacheStdenv
cd-hit
cedille
chafa
chars
chit
choose
click
clippy
clog-cli
cm-rgb
coloursum
cozy
crate2nix
cscope
darktable
dblatexFull
deno
diesel-cli
diffr
dijo
dino
diskonaut
diskus
disnix
djview (djview4)
djvu2pdf
djvulibre
dmtx-utils
dogdns
dot-http
drill
du-dust
dua
dvdauthor
dydisnix
effitask
elan
electrum
emacs (emacs27)
emacs26
emplace
etesync-dav
ethabi
eva
evcxr
exa
fastmod
fd
fend
ffmpeg-full
ffsend
finalfrontier
finalfusion-utils
findomain
fitnesstrax
framac
fselect
gcstar
geany
geckodriver
gegl
gegl_0_4 (gnome3.gegl_0_4)
genpass
genxword
geoclue2
gifski
gimp (gimpPlugins.gimp)
gimpPlugins.gmic
gir-rs
git-backup
git-series
gitAndTools.delta
gitAndTools.git-absorb
gitAndTools.git-codeowners
gitAndTools.git-gone
gitAndTools.git-ignore
gitAndTools.git-interactive-rebase-tool
gitAndTools.git-subset
gitAndTools.git-trim
gitAndTools.git-vanity-hash
gitAndTools.git-workspace
gitAndTools.gitui
gitAndTools.rs-git-fsmonitor
gitoxide
gleam
gnirehtet
gnome-icon-theme (gnome2.gnome-icon-theme ,gnome2.gnome_icon_theme ,gnome2.gnomeicontheme)
gnome3.defaultIconTheme (gnome3.adwaita-icon-theme)
gnome3.ghex
librsvg (gnome3.librsvg)
meld (gnome3.meld)
webkitgtk (gnome3.webkitgtk)
gnomecast
gnumeric
gnvim
gnvim-unwrapped
goattracker
goattracker-stereo
goffice
gping
gpodder
gramps
grex
gst_all_1.gst-editing-services
gst_all_1.gst-plugins-bad
gst_all_1.gst-rtsp-server
hamster
handbrake
haskellPackages.neuron
haskellPackages.notmuch
haskellPackages.reflex-dom
haskellPackages.webkit2gtk3-javascriptcore
heatseeker
hexdino
hexyl
httplz
humanity-icon-theme
hydra-cli
hydron
hyperfine
iconnamingutils
imag
imagemagick
imagemagick7
imagemagick7Big
imagemagickBig
imgproxy
influxdb2
inkscape
inkscape-with-extensions
intecture-agent
intecture-auth
intermodal
ion
itm-tools
just
jwm
jwt-cli
kak-lsp
kbs2
kibi
kitty
knightos-genkfs
knightos-kimg
knightos-mktiupgrade
kondo
kubie
libpst
librespot
libsForQt5.libopenshot (libsForQt512.libopenshot)
libsForQt514.libopenshot
libsForQt515.libopenshot
libwmf
licensor
lieer
lilypond
lilypond-with-fonts
links2
loc
loop
lorri
lsd
luakit
manim
manix
martin
mate.mozo
matrix-synapse-tools.rust-synapse-compress-state
maturin
mcfly
mcomix3
mdbook
mdcat
mdsh
megatools
meilisearch
microserver
miniserve
mlterm
monolith
mopidy-iris
mopidy-local
mopidy-mopify
mopidy-mpd
mopidy-mpris
mopidy-somafm
mopidy-soundcloud
mopidy-spotify-tunigo
mopidy-tunein
mopidy-youtube
mozwire
mpdris2
mu
muchsync
navi
ncspot
neomutt
netbeans
neuron-notes
newsboat
nip2
nix-doc
nix-du
nix-index
nix-query-tree-viewer
nix-simple-deploy
nix-template
nix-update
nixFlakes (nixUnstable)
nixdoc
nixpkgs-fmt
nixpkgs-review
noaa-apt
noteshrink
notmuch
notmuch-addrlookup
noto-fonts-emoji
numix-cursor-theme
nushell
nym
olive-editor
onefetch
onioncircuits
openethereum
openspades
oxipng
page
panopticon
parinfer-rust
pastel
pazi
pcsxr
pdf-redact-tools
pdf2odt
pdfpc
pdfsam-basic
pdftag
peep
perl530Packages.PerlMagick
perl532Packages.PerlMagick
phash
pijul
pithos
powerline-rs
procs
prometheus-wireguard-exporter
pstoedit
ptags
pueue
py-spy
pydb
python37Packages.SQLAlchemy-ImageAttach
python37Packages.Wand
python37Packages.dogtail
python37Packages.etebase
python37Packages.notmuch
python37Packages.notmuch2
python37Packages.pydub
python37Packages.pyvips
python37Packages.pywal
python37Packages.qiskit
python37Packages.qiskit-aer
python37Packages.qiskit-aqua
python37Packages.qiskit-ibmq-provider
python37Packages.qiskit-ignis
python37Packages.qiskit-terra
python37Packages.retworkx
python37Packages.robotframework-selenium2library
python37Packages.robotframework-seleniumlibrary
python37Packages.selenium
python37Packages.sequoia
python37Packages.splinter
python37Packages.tokenizers
python37Packages.transformers
python37Packages.xdot
python38Packages.SQLAlchemy-ImageAttach
python38Packages.Wand
python38Packages.dogtail
python38Packages.etebase
python38Packages.notmuch
python38Packages.notmuch2
python38Packages.pydub
python38Packages.pyvips
pywal (python38Packages.pywal)
python38Packages.qiskit
python38Packages.qiskit-aer
python38Packages.qiskit-aqua
python38Packages.qiskit-ibmq-provider
python38Packages.qiskit-ignis
python38Packages.qiskit-terra
python38Packages.retworkx
python38Packages.robotframework-selenium2library
python38Packages.robotframework-seleniumlibrary
python38Packages.selenium
sequoia (python38Packages.sequoia)
python38Packages.splinter
python38Packages.tokenizers
python38Packages.transformers
xdot (python38Packages.xdot)
python39Packages.SQLAlchemy-ImageAttach
python39Packages.Wand
python39Packages.dogtail
python39Packages.etebase
python39Packages.notmuch
python39Packages.notmuch2
python39Packages.pydub
python39Packages.pyvips
python39Packages.pywal
python39Packages.retworkx
python39Packages.robotframework-selenium2library
python39Packages.robotframework-seleniumlibrary
python39Packages.selenium
python39Packages.sequoia
python39Packages.splinter
python39Packages.tokenizers
python39Packages.xdot
qalculate-gtk
qutebrowser
racket-minimal
rage
rargs
rav1e
rbw
rebazel
recoll
recutils
rednotebook
rep
resvg
rink
ripasso-cursive
ripgrep
ripgrep-all
rls
rnix-hashes
rnix-lsp
rq
rsclock
rtags
ruplacer
rust-analyzer
rust-analyzer-unwrapped
rust-bindgen
rust-cbindgen
rustc
rustfmt
rustracer
rustscan
rustup
sayonara
scaff
sccache
sd
searx
sfxr
shadowenv
shadowsocks-rust
shell-hist
silicon
skim
so
sourcetrail
sozu
spacevim
spotify-tui
starship
stm32cubemx
svd2rust
svgbob
svgcleaner
svlint
svls
synapse-bt
system-syzygy
tagref
taizen
tarssh
tdns-cli
tealdeer
tectonic
termplay
texlab
the-way
tickrs
timelapse-deflicker
tiny
todiff
tokei
topgrade
transmission-gtk
tre-command
tree-sitter
tryton
tunnelto
tydra
uq
uutils-coreutils
uwc
vapoursynth
vapoursynth-editor
variety
vcs
vector
vimPlugins.vim-clap
vips
viu
vivid
void
vscode-extensions.matklad.rust-analyzer
wagyu
wasm-bindgen-cli
wasm-pack
wasmer
wasmtime
watchexec
webmetro
websocat
wg-bond
whitebox-tools
why3
wrangler
wv
xarchiver
xboard
xprite-editor
xsv
xxv
yubikey-personalization-gui
zathura
zbar
zenith
zktree
zola
zoxide
zz

dasJ · 2020-12-15T11:36:59Z

building
build flags: -j8 -l8 SHELL=/nix/store/x9mh477dvw0929zgbpkvpxqy4ifdh5qj-bootstrap-tools/bin/bash
Makefile:153: target '/lib' given more than once in the same rule
cc  -r  -Os -mmacosx-version-min=10.6 -mdynamic-no-pic -nostdlib -keep_private_externs start.s crt.c dyld_glue.s -o crt1.v1.o  -DCRT -DOLD_LIBSYSTEM_SUPPORT
cc  -r  -Os -mmacosx-version-min=10.6 -nostdlib -keep_private_externs start.s crt.c dyld_glue.s -o crt1.v2.o  -DCRT
cc  -r  -Os -mmacosx-version-min=10.6 -nostdlib -keep_private_externs start.s crt.c -o crt1.v3.o  -DADD_PROGRAM_VARS
cc  -r  -Os -mmacosx-version-min=10.6 -nostdlib -keep_private_externs start.s crt.c -o crt1.v4.o  -DADD_PROGRAM_VARS
cc  -r  -Os -mmacosx-version-min=10.6 -nostdlib -keep_private_externs start.s crt.c dyld_glue.s -o gcrt1.o  -DGCRT  -DOLD_LIBSYSTEM_SUPPORT
cc  -r  -Os -static -Wl,-new_linker -nostdlib -keep_private_externs start.s crt.c -o crt0.o
cc  -r  -Os -mmacosx-version-min=10.6  -nostdlib -keep_private_externs dyld_glue.s icplusplus.c -o dylib1.v1.o  -DCFM_GLUE
cc  -r  -Os -mmacosx-version-min=10.6  -nostdlib -keep_private_externs dyld_glue.s -o dylib1.v2.o  -DCFM_GLUE
ld: unknown option: -dynamic-linker=/usr/lib/dyld
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [Makefile:95: dylib1.v2.o] Error 1
make: *** Waiting for unfinished jobs....
ld: unknown option: -dynamic-linker=/usr/lib/dyld
ld: unknown option: -dynamic-linker=/usr/lib/dyld
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [Makefile:81: crt1.v4.o] Error 1
make: *** [Makefile:78: crt1.v3.o] Error 1
ld: unknown option: -dynamic-linker=/usr/lib/dyld
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [Makefile:92: dylib1.v1.o] Error 1
ld: unknown option: -dynamic-linker=/usr/lib/dyld
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [Makefile:75: crt1.v2.o] Error 1
ld: unknown option: -dynamic-linker=/usr/lib/dyld
ld: unknown option: -dynamic-linker=/usr/lib/dyld
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [Makefile:72: crt1.v1.o] Error 1
make: *** [Makefile:84: gcrt1.o] Error 1
builder for '/nix/store/hqvjmq7vf02nga19k601cv6dj65n69nw-Csu-osx-10.11.6.drv' failed with exit code 2
building '/nix/store/5avxzv1d2aywyc69zmjxf9pfqapihxyc-ICU-osx-10.10.5.drv'...
cannot build derivation '/nix/store/i5x7vi3d5m3w95ihkrvrzw7xcyjj0mln-Libsystem-osx-10.12.6.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/b0c4lxgp0ady3rq62p4wp563azh3k7dj-binutils-wrapper-2.31.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/f8j0iymlvpgdxqqlvkhglklmiwb3sdrx-binutils-wrapper-2.31.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/8bpxmh59vh3vzc6r1dzxww6dxm36ma34-bootstrap-stage0-clang-wrapper-7.1.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/xais42qx0870k45mpg0dxzxcxx7r4dnb-bootstrap-stage0-clang-wrapper-7.1.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/z04dxvzgf9w3ajsckkgfws565wcmagj8-bootstrap-stage2-stdenv-darwin.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/rvvjy3w4rnlrlyq44yhjnf3m3363160v-bootstrap-stage3-stdenv-darwin.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/nkdzrzzyi3vl6fw3a48cyf4ym244jjmy-clang-wrapper-7.1.0.drv': 1 dependencies couldn't be built
building '/nix/store/cfaj8qgr4fy15r03zw48cav3hqp1lpn6-gnum4-1.4.18.drv'...
cannot build derivation '/nix/store/ka6j6p8gpnfwddkjd3sqr4xb29fb3fa0-perl-5.32.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/mb10f0l1q7397n1lpi9acn8312v1ivjz-stdenv-darwin.drv': 1 dependencies couldn't be built
error: build of '/nix/store/mb10f0l1q7397n1lpi9acn8312v1ivjz-stdenv-darwin.drv', '/nix/store/ssmyi88945j5api6hyzd3ikpdy0yxvs7-bash-interactive-4.4-p23.drv', '/nix/store/v3jdzpd3s9phyj26h9rw44jxgxbw0a1g-bash-4.4-p23.drv' failed
$ git worktree prune

lblasc · 2020-12-15T12:07:52Z

@dasJ This doesn't look related to rustc changes. Can you maybe cherry-pick it to latest master and try there? Thanks!

zowoq · 2020-12-15T20:22:01Z

Built fd on darwin.

There was an attempt to remove this in NixOS#106886 [1], but there was a darwin compilation failure. Whatever caused the failure then is no longer a problem now. [1] NixOS#106886

An attempt to remove it was made in NixOS#106886, but there was a build failure. Since that failure no longer occurs, remove it now. Based on thefloweringash/nixpkgs@1904236.

lblasc requested review from LnL7, Mic92 and zowoq as code owners December 14, 2020 08:51

lblasc changed the title ~~rustc: cleanup, use correct llvm version~~ [staging] rust: cleanup, use correct llvm version Dec 14, 2020

ofborg bot added the 6.topic: rust label Dec 14, 2020

ofborg bot requested review from globin, cstrahan and madjar December 14, 2020 09:01

ofborg bot added 10.rebuild-darwin: 501+ 10.rebuild-darwin: 501-1000 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000 labels Dec 14, 2020

lblasc force-pushed the rustLLVMrefactor branch from a120f3e to 091400e Compare December 14, 2020 14:50

rustc: cleanup, use correct llvm version

c73d96f

lblasc force-pushed the rustLLVMrefactor branch from 091400e to c73d96f Compare December 14, 2020 15:14

Mic92 merged commit d5bc837 into NixOS:staging Dec 16, 2020

lblasc deleted the rustLLVMrefactor branch December 16, 2020 06:07

reckenrode mentioned this pull request Jul 11, 2023

rustc: remove Darwin special-casing #242749

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[staging] rust: cleanup, use correct llvm version #106886

[staging] rust: cleanup, use correct llvm version #106886

lblasc commented Dec 14, 2020 •

edited

zowoq commented Dec 14, 2020

lblasc commented Dec 14, 2020

Mic92 commented Dec 15, 2020 •

edited

dasJ commented Dec 15, 2020

dasJ commented Dec 15, 2020

lblasc commented Dec 15, 2020

zowoq commented Dec 15, 2020

[staging] rust: cleanup, use correct llvm version #106886

[staging] rust: cleanup, use correct llvm version #106886

Conversation

lblasc commented Dec 14, 2020 • edited

Motivation for this change

Things done

zowoq commented Dec 14, 2020

lblasc commented Dec 14, 2020

Mic92 commented Dec 15, 2020 • edited

dasJ commented Dec 15, 2020

dasJ commented Dec 15, 2020

lblasc commented Dec 15, 2020

zowoq commented Dec 15, 2020

lblasc commented Dec 14, 2020 •

edited

Mic92 commented Dec 15, 2020 •

edited