New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Where to move vendor-imports/mozilla/mozilla-central-reftests/align3? #26884
Comments
That spec-edit was for w3c/csswg-drafts#1432, which had another quite-relevant spec edit that landed as well: This second spec-edit was in response to a resolution in w3c/csswg-drafts#1432 (comment) which removed the influence of align-content/justify-content on abspos descendants, I think. That may mean that all of the tests with RE your main question here: I don't know offhand what the correct spec text to link to would be, at this point, but I can try to find out (and see if any of the other tests are also obsolete). |
@dholbert is there a change in Gecko needed to align with the spec changes that happened here? Would you expect that after that, the Gecko results would be largely the same as Chrome and Firefox? If so, then most of these tests may not have value in finding interop problems, and we might be able to leave just the few that do have different cross-browser results, and a few negative tests to ensure that align-content/justify-content have no effect on abspos descendants. Regardless of the details shake out to be, your feedback and help is much appreciated! |
I need to page this spec area back into my head (and review the edits that have happened since I last looked at it), but it looks to me like a change in Gecko is indeed needed, at least for the That's less than half of the tests in this directory, though. I'll aim to get back to you with thoughts about the other tests in this directory (the Thanks for your work on migrating/merging these tests with the rest of the suite! |
Thanks @dholbert, much appreciated! I'll soon be out for the holidays but I'll check back in eventually :) |
Sorry, the holidays interrupted my "the next few days" plans here. :) Back from holidays now, and this is on my list of things-to-look-at-first. |
I think I misunderstood w3c/csswg-drafts@829a074 and I forgot that another section of spec text still existed. As a result, I think these tests are still valid (particularly the justify-content and align-content ones that I was initially suspicious of). For flexbox, these tests are essentially anchored in Flexbox section 4.1, https://drafts.csswg.org/css-flexbox-1/#abspos-items , which says:
(I had mistakenly thought this text had been removed, but it's still there, and I think still authoritative.) This spec-text implies that the static position should be influenced by the flex container's It also implies that the abspos children's static position should be influenced by the flex container's So: bottom-line, the |
( @foolip I think the last paragraph of my comment above is the answer to your original question here. It sounded like you might be up for making those changes/migrations -- if so, I applaud & support you doing so. :) Thanks!) |
Thank you for digging into that, @dholbert! I take that to mean we should move the tests into css/flexbox/ and css/grid/ and would be happy to send a PR for that. |
Yes. Thank you! |
Links are updated as recommended by dholbert: #26884 (comment) Part of #8615. Fixes #26884.
I've sent #27174 to do the move. |
Links are updated as recommended by dholbert: #26884 (comment) Part of #8615. Fixes #26884.
…vendor-imports, a=testonly Automatic update from web-platform-tests [css-flexbox][css-grid] move tests from vendor-imports (#27174) Links are updated as recommended by dholbert: web-platform-tests/wpt#26884 (comment) Part of web-platform-tests/wpt#8615. Fixes web-platform-tests/wpt#26884. -- wpt-commits: 526de418365074a83b72c5390b50f83c0e06f728 wpt-pr: 27174
…vendor-imports, a=testonly Automatic update from web-platform-tests [css-flexbox][css-grid] move tests from vendor-imports (#27174) Links are updated as recommended by dholbert: web-platform-tests/wpt#26884 (comment) Part of web-platform-tests/wpt#8615. Fixes web-platform-tests/wpt#26884. -- wpt-commits: 526de418365074a83b72c5390b50f83c0e06f728 wpt-pr: 27174 UltraBlame original commit: f5b71ab585edef7e6e792b347e05818521661875
…vendor-imports, a=testonly Automatic update from web-platform-tests [css-flexbox][css-grid] move tests from vendor-imports (#27174) Links are updated as recommended by dholbert: web-platform-tests/wpt#26884 (comment) Part of web-platform-tests/wpt#8615. Fixes web-platform-tests/wpt#26884. -- wpt-commits: 526de418365074a83b72c5390b50f83c0e06f728 wpt-pr: 27174
…vendor-imports, a=testonly Automatic update from web-platform-tests [css-flexbox][css-grid] move tests from vendor-imports (#27174) Links are updated as recommended by dholbert: web-platform-tests/wpt#26884 (comment) Part of web-platform-tests/wpt#8615. Fixes web-platform-tests/wpt#26884. -- wpt-commits: 526de418365074a83b72c5390b50f83c0e06f728 wpt-pr: 27174 UltraBlame original commit: 914697e3dd1f90bfa77edc5fb03aaf1cc0183473
We can now move tests from vendor-imports in the the main test suites under css/ (#8615) and I've sent a few PRs. For align3, however, I have questions. These are the tests:
https://wpt.fyi/results/css/vendor-imports/mozilla/mozilla-central-reftests/align3?run_id=5655021456719872&run_id=5745838489862144&run_id=5657645899841536
They were added by @dholbert and the spec links listed are mostly to https://drafts.csswg.org/css-align-3/#align-abspos-static and https://drafts.csswg.org/css-align-3/#justify-abspos-static. However, those spec sections were removed by @fantasai in w3c/csswg-drafts@829a074, and the remaining spec text is a lot shorter.
What spec text should these now link to?
That should also answer the question of where to move these. If it's not css/css-align/, then it might also be css/css-flexbox/ + css/css-grid/, since all of the tests are named either flex-abspos* or grid-abspos-*.
cc @davidsgrogan @svillar @mrego
The text was updated successfully, but these errors were encountered: