Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak ghcide #106897

Merged
merged 1 commit into from Dec 15, 2020
Merged

Unbreak ghcide #106897

merged 1 commit into from Dec 15, 2020

Conversation

poscat0x04
Copy link
Contributor

@poscat0x04 poscat0x04 commented Dec 14, 2020

Motivation for this change

allows #106705 to be merged

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@@ -100383,7 +100383,6 @@ self: {
license = stdenv.lib.licenses.asl20;
hydraPlatforms = stdenv.lib.platforms.none;
maintainers = with stdenv.lib.maintainers; [ maralorn ];
broken = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll have to remove ghcide from the list of broken-packages in configuration-hackage2nix.yaml instead of editing it directly in this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ghcide is not under broken-packages tho, I don't really know how it's marked broken 🤷. it's really weird.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, that's strange.

Maybe @maralorn knows what is going on here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funfact: We couldn‘t even enter ghcide into the list of broken packages, because I am registered as its maintainer and the hackage2nix doesn‘t let you break maintained packages.

The issue is, that the last hackage-revision of ghcide introduced a test dependency on a package which does not exist on hackage. You can see, that cabal2nix passes it to the derivation with a { .. = null; } and then marks the package as broken. But we have ghcide tests disabled anyways, so that it would actually build …

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shake-bench is used only for benchmarking iirc

@maralorn
Copy link
Member

maralorn commented Dec 15, 2020

I think the best we can do is an unmarkBroken + doDistribute. The only other option I see would be an override in cabal2nix and I don‘t like those.

We have precedent for this with other packages in configuration-common.nix.

@poscat0x04
Copy link
Contributor Author

fixed!

@maralorn
Copy link
Member

I don‘t have a clue what's wrong with ofBorg. But it succeeds on aarch64 and I can build it for x86 locally.

Thanks for the fix!

@maralorn maralorn merged commit 6216df1 into NixOS:haskell-updates Dec 15, 2020
@poscat0x04 poscat0x04 deleted the haskell-updates branch December 16, 2020 00:37
@poscat0x04 poscat0x04 restored the haskell-updates branch December 16, 2020 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants