New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unbreak ghcide #106897
Unbreak ghcide #106897
Conversation
@@ -100383,7 +100383,6 @@ self: { | |||
license = stdenv.lib.licenses.asl20; | |||
hydraPlatforms = stdenv.lib.platforms.none; | |||
maintainers = with stdenv.lib.maintainers; [ maralorn ]; | |||
broken = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you'll have to remove ghcide
from the list of broken-packages
in configuration-hackage2nix.yaml
instead of editing it directly in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ghcide
is not under broken-packages
tho, I don't really know how it's marked broken 🤷. it's really weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, that's strange.
Maybe @maralorn knows what is going on here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Funfact: We couldn‘t even enter ghcide into the list of broken packages, because I am registered as its maintainer and the hackage2nix doesn‘t let you break maintained packages.
The issue is, that the last hackage-revision of ghcide introduced a test dependency on a package which does not exist on hackage. You can see, that cabal2nix passes it to the derivation with a { .. = null; }
and then marks the package as broken. But we have ghcide tests disabled anyways, so that it would actually build …
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shake-bench is used only for benchmarking iirc
78da5d6
to
05106af
Compare
I think the best we can do is an We have precedent for this with other packages in |
05106af
to
cae58e7
Compare
cae58e7
to
5504ab3
Compare
fixed! |
I don‘t have a clue what's wrong with ofBorg. But it succeeds on aarch64 and I can build it for x86 locally. Thanks for the fix! |
Motivation for this change
allows #106705 to be merged
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)