Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.paperspace: mark as broken #107866

Closed
wants to merge 2 commits into from

Conversation

rmcgibbo
Copy link
Contributor

Motivation for this change

These packages are currently failing to build because because they rely out outdated dependencies. But when you look at upstream, it looks like they're hopelessly outdated.

  1. https://github.com/Paperspace/gradient-sdk redirects to https://github.com/Paperspace/gradient-utils (project name changed).
  2. https://github.com/paperspace/paperspace-python has been archived on github, and they've apparently moved to https://github.com/Paperspace/gradient-cli.
  3. I tried for a hot second packing the new versions, and they're a bit of a mess too. They also hardcode strict dependencies on outdated versions of packages like attrs<=19. That might be a project for someone else.

Our paperspace package looks like it hasn't been updated since 2018-06-10, has no tests, and aparently is supposed to interact with a cloud service. So it's pretty unlikely it works anyways. I propose to mark them as broken, or perhaps just remove them.

cc maintainers @thoughtpolice @freezeboy.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@AndersonTorres
Copy link
Member

I suggest create a throw message in aliases.nix, too.

@freezeboy
Copy link
Contributor

I have a pending PR (#103841) to use gradient, maybe you could try it for your use case?

@SuperSandro2000
Copy link
Member

I think we should fix the packages rather then marking them as broken and the linked PR from freezeboy is a good start. Closing this.

@rmcgibbo rmcgibbo deleted the paperspace branch December 29, 2020 15:32
@rmcgibbo
Copy link
Contributor Author

Sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants