Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wad: init at 0.4.6 #107876

Merged
merged 1 commit into from Dec 31, 2020
Merged

wad: init at 0.4.6 #107876

merged 1 commit into from Dec 31, 2020

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Dec 29, 2020

Motivation for this change

WAD lets you analyze given URL(s) and detect technologies used by web
application behind that URL, from the OS and web server level, to the
programming platform and frameworks, as well as server- and client-side
applications, tools and libraries.

https://github.com/CERN-CERT/WAD

Related to #81418

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@pacien pacien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The evaluation seems to fail. Here are a few remarks.

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/tools/security/wad/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/wad/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/wad/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/wad/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/wad/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

@ofborg eval

@fabaff
Copy link
Member Author

fabaff commented Dec 29, 2020

Thanks @pacien and @SuperSandro2000 for your input.

@fabaff
Copy link
Member Author

fabaff commented Dec 29, 2020

Result of nixpkgs-review pr 107876 run on x86_64-linux 1

1 package built:
  • wad

};

propagatedBuildInputs = [
six
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: weird indent here

};

propagatedBuildInputs = [
six
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
six
six

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that I've over-written nixpkgs-fmt's run. Thanks.

Copy link
Contributor

@pacien pacien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107876 run on x86_64-darwin 1

1 package built:
  • wad

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107876 run on x86_64-linux 1

1 package built:
  • wad

@SuperSandro2000 SuperSandro2000 merged commit f6251a5 into NixOS:master Dec 31, 2020
@fabaff fabaff deleted the wad branch December 31, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants