Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consul: use settings from consul.io unit #107853

Closed
wants to merge 2 commits into from
Closed

consul: use settings from consul.io unit #107853

wants to merge 2 commits into from

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Dec 28, 2020 •
edited

Motivation for this change

This change is part of a split of #107798

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cpcloud
Copy link
Contributor Author

cpcloud commented Dec 28, 2020

cc @nh2

@cpcloud
Copy link
Contributor Author

cpcloud commented Dec 29, 2020

Interesting, tests are failing but I can't get them to pass on master either.

@jsosulska jsosulska mentioned this pull request Feb 4, 2021
Closed
@stale
Copy link

stale bot commented Jun 28, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 28, 2021
@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 25, 2022

Closing this out.

@cpcloud cpcloud closed this Jan 25, 2022
@cpcloud cpcloud deleted the consul-from-upstream branch January 25, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@cpcloud