Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pt2-clone: 1.26_fix -> 1.27 #107816

Merged
merged 1 commit into from Dec 29, 2020
Merged

pt2-clone: 1.26_fix -> 1.27 #107816

merged 1 commit into from Dec 29, 2020

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Dec 28, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107816 run on x86_64-linux 1

1 package built:
  • pt2-clone

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107816 run on x86_64-darwin 1

1 package built:
  • pt2-clone

@SuperSandro2000 SuperSandro2000 merged commit efe9ac0 into NixOS:master Dec 29, 2020
@fgaz fgaz deleted the pt2-clone/1.27 branch December 29, 2020 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fgaz @SuperSandro2000