Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tmuxPlugins.onedark-theme: fix entrypoint #107817

Closed
wants to merge 1 commit into from
Closed

tmuxPlugins.onedark-theme: fix entrypoint #107817

wants to merge 1 commit into from

Conversation

andyrichardson
Copy link
Contributor

@andyrichardson andyrichardson commented Dec 28, 2020 •
edited

Motivation for this change

Currently, the resulting target file /nix/store/zrv5g7p1sy3b59dasxb9sqmr8c9v5lly-tmuxplugin-onedark-theme-unstable-2020-06-07/share/tmux-plugins/onedark-theme.tmux doesn't exist.

This is because the tmux file name is incorrect.

Current: onedark-theme.tmux

Actual: tmux-onedark-theme.tmux

CC @sherubthakur @SuperSandro2000

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Dec 28, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit message and PR title to tmuxPlugins.onedark-theme: fix entrypoint

@andyrichardson andyrichardson changed the title Fix bad entrypoint for onedark package tmuxPlugins.onedark-theme: fix entrypoint Dec 28, 2020
@austinbutler
Copy link
Member

Was wondering what I had done wrong when the theme didn't take effect. This fix works for me, thanks.

@andyrichardson it seems you've only fixed the PR title and not the commit message, would you please update that?

@andyrichardson
Copy link
Contributor Author

Hey sorry I haven't had time to get around to this yet - my contribution was a 5s change via the site!

Pulling the repo and changing the commit message is a little more involved 😅 will sort it out later but feel free to make another PR and merge the fix if you want 👍

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107817 run on x86_64-linux 1

1 package built:
  • tmuxPlugins.onedark-theme

@SuperSandro2000 SuperSandro2000 mentioned this pull request Jan 7, 2021
Merged
10 tasks
@andyrichardson andyrichardson deleted the patch-1 branch January 7, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andyrichardson @austinbutler @SuperSandro2000 @Janik-Haag