pavucontrol: dropdown patch for wayland support #107818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emantor
force-pushed
the
topic/pavucontrol_wayland
branch
from
2823b75
to
d30116c
Compare
|
Result of 2 packages built:
|
flokli
reviewed
Dec 28, 2020
Emantor
force-pushed
the
topic/pavucontrol_wayland
branch
from
d30116c
to
e980803
Compare
Pavucontrol employed a button with a popup instead of a dropdown menu for it's dropdown menus. These were rendered offset to the window and maybe even offscreen from the window. Add the upstream patch which fixes this issue. Fixes NixOS#87446
Emantor
force-pushed
the
topic/pavucontrol_wayland
branch
from
e980803
to
e128aa7
Compare
|
Confirmed this to work both on X11 and Wayland (tested inside Weston inside X, but close enough) :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Pavucontrol employed a button with a popup instead of a dropdown menu
for its dropdown menus. These were rendered offset to the window and
maybe even offscreen from the window. Add the upstream patch which fixes
this issue.
Fixes #87446
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)