microplane: init at 0.0.25 #107861
microplane: init at 0.0.25 #107861
Conversation
| -ldflags= | ||
| -X main.version=v${version} |
There was a problem hiding this comment.
| -ldflags= | |
| -X main.version=v${version} | |
| -ldflags="-s -w -X main.version=v${version}" |
There was a problem hiding this comment.
Super fast ⚡ thanks!
Just made the change.
dbirks
force-pushed
the
add-microplane
branch
from
df35547
to
5460ceb
Compare
| # Regenerate deps.nix with the following steps: | ||
| # | ||
| # git clone git@github.com:Clever/microplane.git | ||
| # cd microplane | ||
| # git checkout v<version> | ||
| # dep2nix | ||
|
|
There was a problem hiding this comment.
| # Regenerate deps.nix with the following steps: | |
| # | |
| # git clone git@github.com:Clever/microplane.git | |
| # cd microplane | |
| # git checkout v<version> | |
| # dep2nix | |
| # Regenerate deps.nix with the following commands: | |
| # git clone https://github.com/Clever/microplane.git | |
| # cd microplane | |
| # git checkout v<version> | |
| # dep2nix |
| ''; | ||
|
|
||
| postInstall = '' | ||
| mv $out/bin/microplane $out/bin/mp |
There was a problem hiding this comment.
I am not a fan of putting a binary on every available two or three letter combination. The binary name is microplane and should stay like this. You can add such aliases to your .bashrc.
There was a problem hiding this comment.
Sounds good to me 👍
I was trying to stay close to upstream, and all of their documentation and blog articles I've seen refer to the binary as mp, so that's something to take in to account, but I think giving it its full name microplane won't be confusing. It will also prevent any unnecessary name conflicts too.
There was a problem hiding this comment.
If mp is such a recurring name in official documentations and tutorials, I suggest you create a symlink instead of moving. It will provide no surprises to new users.
There was a problem hiding this comment.
Ok, I did another quick check, and I can't find mention of upstream calling the binary by its full name.
And here's some new pieces of info that may help bring consensus...
Looks like the binary refers to itself as mp:
$ microplane
Microplane makes git changes across many repos
Usage:
mp [command]
Available Commands:
clone Clone all repos targeted by init
docs Generates markdown docs for each command
help Help about any command
init Initialize a microplane workflow
merge Merge pushed changes
plan Plan changes by running a command against cloned repos
push Push planned changes
status Status shows a workflow's progress
Flags:
-h, --help help for mp
-r, --repo string single repo to operate on
Use "mp [command] --help" for more information about a command.
And it looks like upstream calls the binary the shorter name in their releases:
mp-0.0.25-darwin-amd64
mp-0.0.25-linux-amd64
There was a problem hiding this comment.
The symlink should suffice.
There was a problem hiding this comment.
Ok just symlinked microplane to mp.
|
Result of 1 package built:
|
|
Result of 1 package built:
|
dbirks
force-pushed
the
add-microplane
branch
from
5460ceb
to
d0544a2
Compare
dbirks
force-pushed
the
add-microplane
branch
from
d0544a2
to
bd287c9
Compare
Motivation for this change
Wanted to add
microplanesince I'm looking in to using it.Some notes:
Using buildGoPackage instead of buildGoModile, as this project uses dep, so it looks like I need
goDepsthat buildGoPackage provides.Using
subPackages = ["."];because I noticed a binary nameddemowas being built, and I just wanted themicroplanebinary.I'm renaming the binary to
mpbecause that's how the Makefile has it. And I had trouble giving-o $out/bin/mpas a Go build flag, since it would complain that the directory didn't exist, so I just opted to rename it afterwards.There doesn't seem to be a
-vflag orversionsubcommand 😕 , so I'm not sure how to confirm that the version is correct.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)