Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redis: build with TLS support #107860

Merged
merged 2 commits into from Jan 10, 2021
Merged

redis: build with TLS support #107860

merged 2 commits into from Jan 10, 2021

Conversation

thatsmydoing
Copy link
Contributor

Motivation for this change

Redis 6 optionally supports tls.

Things done

This enables it by default with a flag to turn it off if desired.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from globin December 29, 2020 03:34
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107860 run on x86_64-linux 1

8 packages built:
  • python37Packages.pyres
  • python37Packages.python-redis-lock
  • python38Packages.pyres
  • python38Packages.python-redis-lock
  • python39Packages.pyres
  • python39Packages.python-redis-lock
  • redis
  • suricata

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107860 run on x86_64-darwin 1

5 packages failed to build:
  • python37Packages.pyres
  • python38Packages.pyres
  • python38Packages.python-redis-lock
  • python39Packages.pyres
  • python39Packages.python-redis-lock
2 packages built:
  • python37Packages.python-redis-lock
  • redis

pyres fails with

redis.exceptions.ConnectionError: Error 8 connecting to localhost:6379. nodename nor servname provided, or not known.

which is a sandbox issue on darwin

@SuperSandro2000 SuperSandro2000 merged commit f3c1e79 into NixOS:master Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@aanderse aanderse aanderse approved these changes

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thatsmydoing @SuperSandro2000 @aanderse