Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pytest: remove unreproducible test artifacts from output #107825

Merged
merged 1 commit into from Dec 28, 2020
Merged

python3Packages.pytest: remove unreproducible test artifacts from output #107825

merged 1 commit into from Dec 28, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented Dec 28, 2020

Running the tests produced some unreproducible artifacts from the
output directory. This avoids creating some of them and cleans up
others.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from domenkozar, madjar and lsix December 28, 2020 19:26
@raboof raboof changed the base branch from master to staging December 28, 2020 19:30
jonringer
jonringer approved these changes Dec 28, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

cc @FRidh , is there a better way?

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python3Packages.requests

@flokli
Copy link
Contributor

flokli commented Dec 28, 2020

How do these .pyc files differ from other .pyc files produced in other python packages? Why are these reproducible?

@FRidh
Copy link
Member

FRidh commented Dec 28, 2020

How do these .pyc files differ from other .pyc files produced in other python packages? Why are these reproducible?

pytest generates its own bytecode. I tried once with our hook to remove theirs and generature it using Python's own, but that did not work.

I'd prefer not to disable the tests, and remove the generates bytecode instead.

@raboof
python3Packages.pytest: remove unreproducible test artifacts from output
63484ff 
Running the tests produced some unreproducible artifacts from the
output directory. This cleans them up afterwards.
@raboof raboof force-pushed the pytest-remove-unreproducible-test-artifacts-from-output branch from 12ed7f6 to 63484ff Compare December 28, 2020 21:01
@raboof
Copy link
Member Author

raboof commented Dec 28, 2020

I'd prefer not to disable the tests, and remove the generates bytecode instead.

Updated

@flokli flokli merged commit d14d417 into NixOS:staging Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@domenkozar domenkozar Awaiting requested review from domenkozar

@madjar madjar Awaiting requested review from madjar

@lsix lsix Awaiting requested review from lsix

Assignees
No one assigned
Labels
6.topic: python 6.topic: reproducible builds 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@raboof @jonringer @flokli @FRidh