Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
kmod
tools, most importantlydepmod
are needed when cross-compiling a Linux kernel on macOS (Darwin). Currentlydepmod
will just segfault and I diagnosed the problem as follows:kmod
tools are symlinked to one binarybasename(argv[0])
to determine its personalitybasename()
requires thelibgen.h
header on Darwin, which is not includedint
char *
(the actual return type) to be truncated to 32 bitdepmod
crashesThe fix is to include
libgen.h
at a prominent location so that all invocations ofbasename()
are covered.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)