Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitstatus: 1.4.3 -> 1.4.4 #107835

Merged
merged 2 commits into from Dec 29, 2020
Merged

gitstatus: 1.4.3 -> 1.4.4 #107835

merged 2 commits into from Dec 29, 2020

Conversation

mweinelt
Copy link
Member

Motivation for this change

https://github.com/romkatv/gitstatus/releases/tag/v1.4.4

Honestly, I don't know what that change means.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107835 run on x86_64-linux 1

1 package built:
  • gitAndTools.gitstatus

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

@mweinelt
Copy link
Member Author

Good call, clarified it is GPL3 only, as I couldn't find a reference allowing for newer versions.

@mweinelt mweinelt merged commit d80f32e into NixOS:master Dec 29, 2020
@mweinelt mweinelt deleted the gitstatus branch December 29, 2020 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@numkem numkem numkem approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mweinelt @SuperSandro2000 @numkem