Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.shapely: fix build on darwin #107859

Merged
merged 1 commit into from Dec 29, 2020
Merged

python3Packages.shapely: fix build on darwin #107859

merged 1 commit into from Dec 29, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 29, 2020

Motivation for this change

Fixes #107842
cc @rmcgibbo

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 6.topic: python labels Dec 29, 2020
@ofborg ofborg bot requested a review from knedlsepp December 29, 2020 03:03
prusnak
prusnak approved these changes Dec 29, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm I was able to reproduce the bug in #107842 and that the commit in this PR fixes it

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107859 run on x86_64-linux 1

21 packages failed to build:
  • python37Packages.aplpy
  • python37Packages.cartopy
  • python37Packages.geopandas
  • python37Packages.imgaug
  • python37Packages.labelbox
  • python37Packages.mask-rcnn
  • python37Packages.osmnx
  • python37Packages.pyosmium
  • python37Packages.spectral-cube
  • python38Packages.aplpy
  • python38Packages.cartopy
  • python38Packages.geopandas
  • python38Packages.imgaug
  • python38Packages.labelbox
  • python38Packages.mask-rcnn
  • python38Packages.osmnx
  • python38Packages.pyosmium
  • python38Packages.spectral-cube
  • python39Packages.basemap
  • python39Packages.cartopy
  • python39Packages.pyosmium
31 packages built:
  • apache-airflow (python37Packages.apache-airflow)
  • buku
  • cura
  • curaLulzbot
  • flatcam
  • mapproxy
  • python37Packages.basemap
  • python37Packages.descartes
  • python37Packages.flask-admin
  • python37Packages.geoalchemy2
  • python37Packages.owslib
  • python37Packages.pyproj
  • python37Packages.shapely
  • python37Packages.uranium
  • python38Packages.basemap
  • python38Packages.descartes
  • python38Packages.flask-admin
  • python38Packages.geoalchemy2
  • python38Packages.owslib
  • python38Packages.pyproj
  • python38Packages.shapely
  • python38Packages.uranium
  • python39Packages.descartes
  • python39Packages.flask-admin
  • python39Packages.geoalchemy2
  • python39Packages.owslib
  • python39Packages.pyproj
  • python39Packages.shapely
  • python39Packages.uranium
  • qgis
  • qgis-unwrapped
builder for '/nix/store/1yqj2n5nkp1sdvs7hwazgvjbibk7nk53-python3.7-labelbox-2.4.9.drv' failed with exit code 1; last 10 log lines:
adding 'labelbox-2.4.9.dist-info/top_level.txt'
adding 'labelbox-2.4.9.dist-info/RECORD'
removing build/bdist.linux-x86_64/wheel
Finished executing setuptoolsBuildPhase
installing
Executing pipInstallPhase
/build/labelbox-2.4.9/dist /build/labelbox-2.4.9
Processing ./labelbox-2.4.9-py3-none-any.whl
ERROR: Could not find a version that satisfies the requirement backports-datetime-fromisoformat==1.0.0 (from labelbox)
ERROR: No matching distribution found for backports-datetime-fromisoformat==1.0.0

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107859 run on x86_64-darwin 1

3 packages marked as broken and skipped:
  • flatcam
  • python37Packages.mask-rcnn
  • python38Packages.mask-rcnn
19 packages failed to build:
  • apache-airflow (python37Packages.apache-airflow)
  • python37Packages.aplpy
  • python37Packages.cartopy
  • python37Packages.geopandas
  • python37Packages.labelbox
  • python37Packages.osmnx
  • python37Packages.pyosmium
  • python37Packages.spectral-cube
  • python38Packages.aplpy
  • python38Packages.cartopy
  • python38Packages.geopandas
  • python38Packages.labelbox
  • python38Packages.osmnx
  • python38Packages.pyosmium
  • python38Packages.spectral-cube
  • python39Packages.basemap
  • python39Packages.cartopy
  • python39Packages.labelbox
  • python39Packages.pyosmium
21 packages built:
  • mapproxy
  • python37Packages.basemap
  • python37Packages.descartes
  • python37Packages.flask-admin
  • python37Packages.geoalchemy2
  • python37Packages.owslib
  • python37Packages.pyproj
  • python37Packages.shapely
  • python38Packages.basemap
  • python38Packages.descartes
  • python38Packages.flask-admin
  • python38Packages.geoalchemy2
  • python38Packages.owslib
  • python38Packages.pyproj
  • python38Packages.shapely
  • python39Packages.descartes
  • python39Packages.flask-admin
  • python39Packages.geoalchemy2
  • python39Packages.owslib
  • python39Packages.pyproj
  • python39Packages.shapely

@rmcgibbo
Copy link
Contributor

LGTM.

@SuperSandro2000 SuperSandro2000 merged commit 339fccb into NixOS:master Dec 29, 2020
@marsam marsam deleted the fix-shapely-darwin branch May 31, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@knedlsepp knedlsepp Awaiting requested review from knedlsepp

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python3Packages.shapely: broken on darwin?
4 participants
@marsam @SuperSandro2000 @rmcgibbo @prusnak