Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smesh, pythonPackages.{pythonocc-core,cadquery}: Fix building on darwin #107806

Merged
merged 4 commits into from Dec 30, 2020
Merged

smesh, pythonPackages.{pythonocc-core,cadquery}: Fix building on darwin #107806

merged 4 commits into from Dec 30, 2020

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change

#106433

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 28, 2020
@SuperSandro2000 SuperSandro2000 mentioned this pull request Dec 28, 2020
Merged
10 tasks
@ofborg ofborg bot requested a review from gebner December 28, 2020 15:59
@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 107806 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • cq-editor
1 package failed to build:
  • python37Packages.cadquery
8 packages built:
  • inkcut
  • python37Packages.enamlx
  • python37Packages.pythonocc-core
  • python38Packages.enamlx
  • python38Packages.pythonocc-core
  • python39Packages.enamlx
  • python39Packages.pythonocc-core
  • smesh

@SuperSandro2000 SuperSandro2000 changed the title smesh, pythonPackages.pythonocc-core: Fix building on darwin smesh, pythonPackages.{pythonocc-core,cadquery}: Fix building on darwin Dec 28, 2020
@ofborg ofborg bot requested review from marcus7070 and costrouc December 28, 2020 18:45
@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 107806 run on x86_64-darwin 1

10 packages built:
  • inkcut
  • inkscape-extensions.inkcut
  • python37Packages.cadquery
  • python37Packages.enamlx
  • python37Packages.pythonocc-core
  • python38Packages.enamlx
  • python38Packages.pythonocc-core
  • python39Packages.enamlx
  • python39Packages.pythonocc-core
  • smesh

@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 107806 run on x86_64-linux 1

1 package failed to build:
  • cq-editor
9 packages built:
  • inkcut
  • inkscape-extensions.inkcut
  • python37Packages.cadquery
  • python37Packages.enamlx
  • python37Packages.pythonocc-core
  • python38Packages.enamlx
  • python38Packages.pythonocc-core
  • python39Packages.enamlx
  • python39Packages.pythonocc-core
rootdir: /build/source
plugins: flaky-3.7.0
collected 45 items
============================ no tests ran in 3.21s =============================
ERROR: Wrong expression passed to '-k': \
not test_turtle_launch \
and not test_umr_skip_cython \
and not test_umr_pathlist: at column 1: unexpected character "\"
cannot build derivation '/nix/store/n5y6cjihxrd3bip0whnngha6awgymfrd-python3.7-spyder-3.3.6.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/wsv0ngmv33n4lpghdq8d13a3bw2l54d3-cq-editor-0.1.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/8zw108br8blaavdr5xc96116zhnxq1mq-env.drv': 1 dependencies couldn't be built

@jonringer
Copy link
Contributor

the pytest error is becuase pytest>=6 doesn't allow for multi-line expressions to be passed to -k. The related package should be converted to using pytestCheckHook which is compatible with pytest6

@marcus7070 marcus7070 mentioned this pull request Dec 30, 2020
Merged
10 tasks
jonringer
jonringer approved these changes Dec 30, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 107806 run on x86_64-linux 1

14 packages built:
  • cq-editor
  • inkcut
  • inkscape-extensions.inkcut
  • python37Packages.cadquery
  • python37Packages.enamlx
  • python37Packages.pythonocc-core
  • python37Packages.spyder-kernels_0_5
  • python37Packages.spyder_3
  • python38Packages.enamlx
  • python38Packages.pythonocc-core
  • python38Packages.spyder-kernels_0_5
  • python38Packages.spyder_3
  • python39Packages.enamlx
  • python39Packages.pythonocc-core

@jonringer jonringer merged commit 0faf465 into NixOS:master Dec 30, 2020
@marcus7070
Copy link
Member

Thanks @SuperSandro2000.

@SuperSandro2000 SuperSandro2000 deleted the inkcut-deps-darwin branch December 30, 2020 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@marcus7070 marcus7070 marcus7070 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@gebner gebner Awaiting requested review from gebner

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SuperSandro2000 @jonringer @marcus7070