Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clojure-lsp: 20201207T142850 -> 20201228T020543 #107809

Merged
merged 1 commit into from Dec 30, 2020
Merged

clojure-lsp: 20201207T142850 -> 20201228T020543 #107809

merged 1 commit into from Dec 30, 2020

Conversation

thiagokokada
Copy link
Contributor

Motivation for this change

Multiple updates: https://github.com/clojure-lsp/clojure-lsp

Switch to the new repository. Also, switch to packaging uberjar instead of rewriting the lein-bin file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thiagokokada
clojure-lsp: 20201207T142850 -> 20201228T020543
7923d59 
Also, switch to packaging uberjar instead of rewriting the lein-bin
file.
@thiagokokada
Copy link
Contributor Author

Result of nixpkgs-review pr 107809 1

1 package built:
  • clojure-lsp

ericdallo
ericdallo approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@ericdallo ericdallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ofborg ofborg bot requested a review from ericdallo December 28, 2020 16:12
@thiagokokada
Copy link
Contributor Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 28, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@ericdallo
Copy link
Member

/status needs_merger

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107809 run on x86_64-linux 1

1 package built:
  • clojure-lsp

@marvin-mk2 marvin-mk2 bot requested a review from kevincox December 28, 2020 19:59
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/311

@AndersonTorres AndersonTorres merged commit 2518b48 into NixOS:master Dec 30, 2020
@thiagokokada thiagokokada deleted the bump-clojure-lsp branch December 30, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@ericdallo ericdallo Awaiting requested review from ericdallo

@kevincox kevincox Awaiting requested review from kevincox

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 awaiting_merger marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@thiagokokada @ericdallo @SuperSandro2000 @nixos-discourse @AndersonTorres