Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dconf: fix cross compilation #107808

Merged
merged 2 commits into from Jan 1, 2021
Merged

dconf: fix cross compilation #107808

merged 2 commits into from Jan 1, 2021

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Dec 28, 2020

Vala doesn't yet cross-compile, and gtk-doc uses some
gobject-introspection bits (and gobject-introspection doesn't
cross-compile either).

Motivation for this change

Cross-compiled NixOS

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
dconf: fix cross compilation
e69bc44 
Vala doesn't yet cross-compile, and gtk-doc uses some
gobject-introspection bits (and gobject-introspection doesn't
cross-compile either).
@flokli
dconf: remove libxml2
195bb48 
This doesn't seem to be required anymore (?)
@ofborg ofborg bot requested a review from jtojnar December 28, 2020 17:06
@flokli flokli merged commit 3050545 into NixOS:staging Jan 1, 2021
@flokli flokli deleted the dconf-fix-cross branch January 1, 2021 21:01
@flokli flokli mentioned this pull request Jan 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr Awaiting requested review from samueldr

@hedning hedning Awaiting requested review from hedning

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @jtojnar