Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

anki-bin: 2.1.36 -> 2.1.38 #107867

Merged
merged 1 commit into from Dec 29, 2020
Merged

anki-bin: 2.1.36 -> 2.1.38 #107867

merged 1 commit into from Dec 29, 2020

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Dec 29, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Atemu
Copy link
Member Author

Atemu commented Dec 29, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 29, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107867 run on x86_64-linux 1

1 package built:
  • anki-bin

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107867 run on x86_64-darwin 1

1 package built:
  • anki-bin

@SuperSandro2000 SuperSandro2000 merged commit 4d8414c into NixOS:master Dec 29, 2020
@Atemu Atemu deleted the update/anki-bin branch December 29, 2020 18:05
@Atemu
Copy link
Member Author

Atemu commented Dec 29, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikanezrimaya vikanezrimaya Awaiting requested review from vikanezrimaya

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Atemu @SuperSandro2000