New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emulsion: init at 7.2 #107831
emulsion: init at 7.2 #107831
Conversation
Result of 1 package built:
|
Result of 1 package built:
|
28f69dc
to
774abfb
Compare
774abfb
to
aa1eb5c
Compare
installPhase = '' | ||
runHook preInstall | ||
install -D $releaseDir/emulsion $out/bin/emulsion | ||
'' + lib.optionals (stdenv.isLinux) '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'' + lib.optionals (stdenv.isLinux) '' | |
'' + lib.optional (stdenv.isLinux) '' |
Try this and tell if something happened.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error: cannot coerce a list to a string, at /home/bart/source/nixpkgs/pkgs/applications/graphics/emulsion/default.nix:67:18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is optionals failing? Did you read the ofborg log?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not following you.
optionals
is working for me an optional
gives me the above error.
ofborg seems to get that error with the s. I'm confused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am trying to make sense of this:
while evaluating the attribute 'installPhase' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-0/pkgs/applications/graphics/emulsion/default.nix:67:3:
cannot coerce a list to a string, at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-0/pkgs/applications/graphics/emulsion/default.nix:67:18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, me too!
I get the error when I remove the s
, an ofborg gets it with the code in it's current state...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'' + lib.optionals (stdenv.isLinux) '' | |
'' + lib.optionalString stdenv.isLinux '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)