Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_1password: 1.7.0 -> 1.8.0 #107843

Merged
merged 1 commit into from Jan 6, 2021
Merged

_1password: 1.7.0 -> 1.8.0 #107843

merged 1 commit into from Jan 6, 2021

Conversation

freezeboy
Copy link
Contributor

Motivation for this change

I ran the program for x86_64-linux, and just updated the hashes for 32bit and darwin, so please try to run the binary before merging on those plaforms

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from marsam and joelburget December 28, 2020 21:51
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107843 run on x86_64-linux 1

1 package built:
  • _1password

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107843 run on x86_64-darwin 1

1 package built:
  • _1password

@marsam marsam merged commit 0b8b118 into NixOS:master Jan 6, 2021
@freezeboy freezeboy deleted the update-1password branch January 6, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@marsam marsam Awaiting requested review from marsam

@joelburget joelburget Awaiting requested review from joelburget

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@freezeboy @SuperSandro2000 @marsam