Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clipmenu: 6.1.0 -> 6.2.0 and fixes #107840

Merged
merged 2 commits into from Dec 31, 2020
Merged

clipmenu: 6.1.0 -> 6.2.0 and fixes #107840

merged 2 commits into from Dec 31, 2020

Conversation

ck3d
Copy link
Contributor

@ck3d ck3d commented Dec 28, 2020

Motivation for this change
  1. update to 6.2.0
  2. fix issues in clipctl, clipmenud and clipmenud.service (see commit message)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ck3d
clipmenu: 6.1.0 -> 6.2.0
f6ff5f8
@ck3d
clipmenu: Fix systemd service, clipctl, clipmenud
2f81c7a 
clipmenud.service:
- fix path to clipmenud

clipmenud:
- fix "ignore window" function by adding xdotools
- add coreutils to make clipmenud fully self contained (needed for
  systemd service)

clipctl:
- fix process name, caused by wrapping clipmenud
@ofborg ofborg bot requested a review from jb55 December 28, 2020 21:42
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107840 run on x86_64-linux 1

1 package built:
  • clipmenu

@Lassulus Lassulus merged commit 5ab6b50 into NixOS:master Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@jb55 jb55 Awaiting requested review from jb55

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ck3d @SuperSandro2000 @Lassulus