Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacs2nix: update to fix locale issues and a missing elpa package #107839

Merged
merged 1 commit into from Dec 30, 2020
Merged

emacs2nix: update to fix locale issues and a missing elpa package #107839

merged 1 commit into from Dec 30, 2020

Conversation

collares
Copy link
Member

@collares collares commented Dec 28, 2020 •
edited

Motivation for this change

Should fix elpa updates in the overlay.

Things done
  • Built on platform(s)
    • NixOS

@collares collares mentioned this pull request Dec 28, 2020
Closed
SuperSandro2000
SuperSandro2000 requested changes Dec 28, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the PR title and commit to:
emacs2nix: update

@collares collares changed the title emacs: update emacs2nix emacs2nix: update Dec 28, 2020
@collares collares changed the title emacs2nix: update emacs2nix: update to fix locale issues and a missing elpa package Dec 28, 2020
talyz
talyz approved these changes Dec 30, 2020
View reviewed changes
Copy link
Contributor

@talyz talyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well and seems to fix the locale issue. Tested by running the update-elpa script with env -u LANG which crashed the previous version.

@talyz talyz merged commit ee5a73f into NixOS:master Dec 30, 2020
@collares collares deleted the update-emacs2nix branch December 30, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talyz talyz talyz approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: emacs 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@collares @talyz @SuperSandro2000