Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.jupyterlab: 2.2.9 -> 3.0.11 #107869

Merged
merged 5 commits into from Mar 20, 2021
Merged

python3Packages.jupyterlab: 2.2.9 -> 3.0.11 #107869

merged 5 commits into from Mar 20, 2021

Conversation

elohmeier
Copy link
Contributor

@elohmeier elohmeier commented Dec 29, 2020 •
edited

Motivation for this change

Update to the latest release.

Things done

Added new dependencies, update packages.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from costrouc and zimbatm December 29, 2020 08:29
SuperSandro2000
SuperSandro2000 requested changes Dec 29, 2020
View reviewed changes
pkgs/development/python-modules/jupyter-packaging/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/jupyter_server/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/jupyter_server/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/jupyter_server/default.nix Show resolved Hide resolved
pkgs/development/python-modules/jupyter_server/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/jupyterlab_server/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/nbclassic/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/nbclassic/default.nix Outdated Show resolved Hide resolved
@elohmeier
Copy link
Contributor Author

Hi @SuperSandro2000, thanks for your review and feedback. I've added the pytest checks where possible and integrated your change requests.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107869 run on x86_64-darwin 1

7 packages marked as broken and skipped:
  • python37Packages.skein
  • python38Packages.skein
  • python39Packages.jupyter_server
  • python39Packages.jupyterlab
  • python39Packages.jupyterlab_server
  • python39Packages.nbclassic
  • python39Packages.skein
32 packages failed to build:
  • python37Packages.Nikola
  • python37Packages.datashader
  • python37Packages.intake
  • python37Packages.jupyter_server
  • python37Packages.jupyterlab
  • python37Packages.jupyterlab_server
  • python37Packages.nbclassic
  • python37Packages.nbclient
  • python37Packages.papermill
  • python37Packages.qiskit
  • python37Packages.qiskit-aer
  • python37Packages.qiskit-aqua
  • python37Packages.qiskit-ibmq-provider
  • python37Packages.qiskit-ignis
  • python38Packages.Nikola
  • python38Packages.datashader
  • python38Packages.intake
  • python38Packages.jupyter_server
  • python38Packages.jupyterlab
  • python38Packages.jupyterlab_server
  • python38Packages.nbclassic
  • python38Packages.nbclient
  • python38Packages.papermill
  • python38Packages.qiskit
  • python38Packages.qiskit-aer
  • python38Packages.qiskit-aqua
  • python38Packages.qiskit-ibmq-provider
  • python38Packages.qiskit-ignis
  • python39Packages.Nikola
  • python39Packages.nbclient
  • python39Packages.papermill
  • python39Packages.scikit-tda
107 packages built:
  • ansible-lint (python38Packages.ansible-lint)
  • jupyter
  • python37Packages.ansible-kernel
  • python37Packages.ansible-lint
  • python37Packages.batchspawner
  • python37Packages.colorcet
  • python37Packages.cufflinks
  • python37Packages.dockerspawner
  • python37Packages.holoviews
  • python37Packages.hvplot
  • python37Packages.ipydatawidgets
  • python37Packages.ipympl
  • python37Packages.ipyvue
  • python37Packages.ipyvuetify
  • python37Packages.ipywidgets
  • python37Packages.jupyter
  • python37Packages.jupyter-packaging
  • python37Packages.jupyter-sphinx
  • python37Packages.jupyterhub
  • python37Packages.jupyterhub-ldapauthenticator
  • python37Packages.jupyterhub-systemdspawner
  • python37Packages.jupyterhub-tmpauthenticator
  • python37Packages.jupyterlab-git
  • python37Packages.jupyterlab_launcher
  • python37Packages.kmapper
  • python37Packages.lightparam
  • python37Packages.myfitnesspal
  • python37Packages.nbdime
  • python37Packages.nbsmoke
  • python37Packages.nix-kernel
  • python37Packages.notebook
  • python37Packages.notedown
  • python37Packages.oauthenticator
  • python37Packages.perfplot
  • python37Packages.qiskit-terra
  • python37Packages.rich
  • python37Packages.runway-python
  • python37Packages.scikit-tda
  • python37Packages.stytra
  • python37Packages.vega
  • python37Packages.widgetsnbextension
  • python38Packages.ansible-kernel
  • python38Packages.batchspawner
  • python38Packages.colorcet
  • python38Packages.cufflinks
  • python38Packages.dockerspawner
  • python38Packages.holoviews
  • python38Packages.hvplot
  • python38Packages.ipydatawidgets
  • python38Packages.ipympl
  • python38Packages.ipyvue
  • python38Packages.ipyvuetify
  • python38Packages.ipywidgets
  • python38Packages.jupyter
  • python38Packages.jupyter-packaging
  • python38Packages.jupyter-sphinx
  • python38Packages.jupyterhub
  • python38Packages.jupyterhub-ldapauthenticator
  • python38Packages.jupyterhub-systemdspawner
  • python38Packages.jupyterhub-tmpauthenticator
  • python38Packages.jupyterlab-git
  • python38Packages.jupyterlab_launcher
  • python38Packages.kmapper
  • python38Packages.lightparam
  • python38Packages.myfitnesspal
  • python38Packages.nbdime
  • python38Packages.nbsmoke
  • python38Packages.nix-kernel
  • python38Packages.notebook
  • python38Packages.notedown
  • python38Packages.oauthenticator
  • python38Packages.perfplot
  • python38Packages.qiskit-terra
  • python38Packages.rich
  • python38Packages.runway-python
  • python38Packages.scikit-tda
  • python38Packages.stytra
  • python38Packages.vega
  • python38Packages.widgetsnbextension
  • python39Packages.ansible-kernel
  • python39Packages.ansible-lint
  • python39Packages.batchspawner
  • python39Packages.dockerspawner
  • python39Packages.ipympl
  • python39Packages.ipyvue
  • python39Packages.ipyvuetify
  • python39Packages.ipywidgets
  • python39Packages.jupyter
  • python39Packages.jupyter-packaging
  • python39Packages.jupyter-sphinx
  • python39Packages.jupyterhub
  • python39Packages.jupyterhub-ldapauthenticator
  • python39Packages.jupyterhub-systemdspawner
  • python39Packages.jupyterhub-tmpauthenticator
  • python39Packages.jupyterlab-git
  • python39Packages.jupyterlab_launcher
  • python39Packages.kmapper
  • python39Packages.lightparam
  • python39Packages.myfitnesspal
  • python39Packages.nbdime
  • python39Packages.nix-kernel
  • python39Packages.notebook
  • python39Packages.notedown
  • python39Packages.oauthenticator
  • python39Packages.perfplot
  • python39Packages.rich
  • python39Packages.widgetsnbextension

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107869 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • ihaskell
  • python37Packages.skein
  • python38Packages.skein
  • python39Packages.skein
1 package blacklisted:
  • tests.nixos-functions.nixos-test
4 packages failed to build:
  • python37Packages.Nikola
  • python38Packages.Nikola
  • python39Packages.Nikola
  • python39Packages.scikit-tda
130 packages built:
  • ansible-lint (python38Packages.ansible-lint)
  • jupyter
  • python37Packages.ansible-kernel
  • python37Packages.ansible-lint
  • python37Packages.batchspawner
  • python37Packages.colorcet
  • python37Packages.cufflinks
  • python37Packages.datashader
  • python37Packages.dockerspawner
  • python37Packages.holoviews
  • python37Packages.hvplot
  • python37Packages.intake
  • python37Packages.ipydatawidgets
  • python37Packages.ipympl
  • python37Packages.ipyvue
  • python37Packages.ipyvuetify
  • python37Packages.ipywidgets
  • python37Packages.jupyter
  • python37Packages.jupyter-packaging
  • python37Packages.jupyter-sphinx
  • python37Packages.jupyter_server
  • python37Packages.jupyterhub
  • python37Packages.jupyterhub-ldapauthenticator
  • python37Packages.jupyterhub-systemdspawner
  • python37Packages.jupyterhub-tmpauthenticator
  • python37Packages.jupyterlab
  • python37Packages.jupyterlab-git
  • python37Packages.jupyterlab_launcher
  • python37Packages.jupyterlab_server
  • python37Packages.kmapper
  • python37Packages.lightparam
  • python37Packages.myfitnesspal
  • python37Packages.nbclassic
  • python37Packages.nbclient
  • python37Packages.nbdime
  • python37Packages.nbsmoke
  • python37Packages.nix-kernel
  • python37Packages.notebook
  • python37Packages.notedown
  • python37Packages.oauthenticator
  • python37Packages.papermill
  • python37Packages.perfplot
  • python37Packages.qiskit
  • python37Packages.qiskit-aer
  • python37Packages.qiskit-aqua
  • python37Packages.qiskit-ibmq-provider
  • python37Packages.qiskit-ignis
  • python37Packages.qiskit-terra
  • python37Packages.rich
  • python37Packages.runway-python
  • python37Packages.scikit-tda
  • python37Packages.stytra
  • python37Packages.vega
  • python37Packages.widgetsnbextension
  • python38Packages.ansible-kernel
  • python38Packages.batchspawner
  • python38Packages.colorcet
  • python38Packages.cufflinks
  • python38Packages.datashader
  • python38Packages.dockerspawner
  • python38Packages.holoviews
  • python38Packages.hvplot
  • python38Packages.intake
  • python38Packages.ipydatawidgets
  • python38Packages.ipympl
  • python38Packages.ipyvue
  • python38Packages.ipyvuetify
  • python38Packages.ipywidgets
  • python38Packages.jupyter
  • python38Packages.jupyter-packaging
  • python38Packages.jupyter-sphinx
  • python38Packages.jupyter_server
  • python38Packages.jupyterhub
  • python38Packages.jupyterhub-ldapauthenticator
  • python38Packages.jupyterhub-systemdspawner
  • python38Packages.jupyterhub-tmpauthenticator
  • python38Packages.jupyterlab
  • python38Packages.jupyterlab-git
  • python38Packages.jupyterlab_launcher
  • python38Packages.jupyterlab_server
  • python38Packages.kmapper
  • python38Packages.lightparam
  • python38Packages.myfitnesspal
  • python38Packages.nbclassic
  • python38Packages.nbclient
  • python38Packages.nbdime
  • python38Packages.nbsmoke
  • python38Packages.nix-kernel
  • python38Packages.notebook
  • python38Packages.notedown
  • python38Packages.oauthenticator
  • python38Packages.papermill
  • python38Packages.perfplot
  • python38Packages.qiskit
  • python38Packages.qiskit-aer
  • python38Packages.qiskit-aqua
  • python38Packages.qiskit-ibmq-provider
  • python38Packages.qiskit-ignis
  • python38Packages.qiskit-terra
  • python38Packages.rich
  • python38Packages.runway-python
  • python38Packages.scikit-tda
  • python38Packages.stytra
  • python38Packages.vega
  • python38Packages.widgetsnbextension
  • python39Packages.batchspawner
  • python39Packages.dockerspawner
  • python39Packages.ipympl
  • python39Packages.ipyvue
  • python39Packages.ipyvuetify
  • python39Packages.ipywidgets
  • python39Packages.jupyter
  • python39Packages.jupyter-packaging
  • python39Packages.jupyter-sphinx
  • python39Packages.jupyterhub
  • python39Packages.jupyterhub-ldapauthenticator
  • python39Packages.jupyterhub-systemdspawner
  • python39Packages.jupyterhub-tmpauthenticator
  • python39Packages.jupyterlab-git
  • python39Packages.jupyterlab_launcher
  • python39Packages.kmapper
  • python39Packages.lightparam
  • python39Packages.nbclient
  • python39Packages.nbdime
  • python39Packages.nix-kernel
  • python39Packages.notebook
  • python39Packages.notedown
  • python39Packages.oauthenticator
  • python39Packages.papermill
  • python39Packages.widgetsnbextension

@elohmeier
Copy link
Contributor Author

Thanks @SuperSandro2000 @costrouc for your review. I've applied your suggestions and updated the packages to their latest versions.

@elohmeier elohmeier changed the title python3Packages.jupyterlab: 2.2.9 -> 3.0.0 python3Packages.jupyterlab: 2.2.9 -> 3.0.11 Mar 17, 2021
@ofborg ofborg bot requested a review from costrouc March 17, 2021 18:06
@SuperSandro2000 SuperSandro2000 merged commit 3510e37 into NixOS:master Mar 20, 2021
@elohmeier elohmeier deleted the jupyter3 branch July 6, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@zimbatm zimbatm Awaiting requested review from zimbatm

@costrouc costrouc Awaiting requested review from costrouc

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elohmeier @SuperSandro2000 @costrouc