Switch CI from Travis to GitHub Actions #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
reviewed
Dec 29, 2020
.github/workflows/test.yml
Outdated
| - name: Install dependencies | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install sdcc |
There was a problem hiding this comment.
I think we don't actually need sdcc on CI (perhaps as a separate action, but for now I think it is enough that the few people who modify the firmware also build it locally).
|
GHA isn't triggering for this PR because it's from a fork. I've opened a PR to master on my fork where GHA does then trigger, so you can view the result here: https://github.com/adamgreig/glasgow/pull/1 Once the workflow exists in the upstream repository, it should run for subsequent PRs, including from forks. |
whitequark
approved these changes
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first pass at using GHA instead of Travis for CI. It should perform the same actions as Travis currently does.
Currently this doesn't perform any caching; we could cache both the pip downloads for YoWASP and the built WASM objects fairly easily if that's desirable. This doesn't remove the Travis CI file either.