Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a52dec: 0.7.4p4 -> 0.7.4 #107847

Merged
merged 1 commit into from Dec 29, 2020
Merged

a52dec: 0.7.4p4 -> 0.7.4 #107847

merged 1 commit into from Dec 29, 2020

Conversation

freezeboy
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

prusnak
prusnak requested changes Dec 28, 2020
View reviewed changes
pkgs/development/libraries/a52dec/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/a52dec/default.nix Outdated Show resolved Hide resolved
@freezeboy
Copy link
Contributor Author

pushed asked changes

@prusnak prusnak merged commit ef7116f into NixOS:master Dec 29, 2020
@freezeboy freezeboy deleted the update-a52dec branch December 29, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@freezeboy @prusnak