Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abseil-cpp: 20200225.2 -> 20200923.2 #107846

Closed
wants to merge 1 commit into from
Closed

abseil-cpp: 20200225.2 -> 20200923.2 #107846

wants to merge 1 commit into from

Conversation

freezeboy
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from andersk December 28, 2020 22:06
@andersk
Copy link
Contributor

andersk commented Dec 28, 2020

Last I checked, upgrading abseil-cpp breaks a number of packages; see #100827. We may need to provide multiple versions.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107846 run on x86_64-linux 1

5 packages marked as broken and skipped:
  • google-cloud-cpp
  • linuxPackages_4_4.sysdig
  • linuxPackages_4_9.sysdig
  • linuxPackages_hardkernel_4_14.sysdig
  • linuxPackages_hardkernel_latest.sysdig
13 packages failed to build:
  • linuxPackages-libre.sysdig
  • or-tools
  • python37Packages.mask-rcnn
  • python37Packages.ortools
  • python37Packages.tensorflow_2 (python37Packages.tensorflow-build_2)
  • python38Packages.mask-rcnn
  • python38Packages.ortools
  • python38Packages.tensorflow_2 (python38Packages.tensorflow-build_2)
  • python39Packages.ortools
  • python39Packages.tensorflow_2 (python39Packages.tensorflow-build_2)
  • rippled
  • rippled-validator-keys-tool
  • tts
21 packages built:
  • abseil-cpp
  • bear
  • grpc
  • linuxPackages.sysdig (linuxPackages_5_4.sysdig)
  • linuxPackages_4_14.sysdig
  • linuxPackages_4_19.sysdig
  • linuxPackages_5_10.sysdig (linuxPackages_latest.sysdig)
  • linuxPackages_5_9.sysdig
  • linuxPackages_hardened.sysdig
  • linuxPackages_latest-libre.sysdig
  • linuxPackages_latest_hardened.sysdig
  • linuxPackages_latest_xen_dom0.sysdig
  • linuxPackages_latest_xen_dom0_hardened.sysdig
  • linuxPackages_lqx.sysdig
  • linuxPackages_testing_bcachefs.sysdig
  • linuxPackages_xen_dom0.sysdig
  • linuxPackages_xen_dom0_hardened.sysdig
  • linuxPackages_zen.sysdig
  • murmur
  • qv2ray
  • sysdig

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107846 run on x86_64-darwin 1

5 packages marked as broken and skipped:
  • python37Packages.mask-rcnn
  • python38Packages.mask-rcnn
  • python39Packages.tensorflow-build_2
  • python39Packages.tensorflow_2
  • sysdig
2 packages failed to build and already failed to build on hydra master:
4 packages failed to build and are new build failures:
  • python37Packages.tensorflow_2: log was empty
  • (python37Packages.tensorflow-build_2): log was empty
  • python38Packages.tensorflow_2: log was empty
  • (python38Packages.tensorflow-build_2): log was empty
2 packages built:
  • abseil-cpp
  • grpc

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107846 run on x86_64-linux 1

7 packages marked as broken and skipped:
  • google-cloud-cpp
  • linuxPackages_4_4.sysdig
  • linuxPackages_4_9.sysdig
  • linuxPackages_hardkernel_4_14.sysdig
  • linuxPackages_hardkernel_latest.sysdig
  • python39Packages.tensorflow-build_2
  • python39Packages.tensorflow_2
13 packages failed to build and are new build failures:
  • linuxPackages-libre.sysdig: log was empty
  • or-tools: log https://termbin.com/5hud
  • python37Packages.mask-rcnn: log was empty
  • python37Packages.ortools: log https://termbin.com/rlf5
  • python37Packages.tensorflow_2: log was empty
  • (python37Packages.tensorflow-build_2): log was empty
  • python38Packages.mask-rcnn: log was empty
  • python38Packages.ortools: log https://termbin.com/3944
  • python38Packages.tensorflow_2: log was empty
  • (python38Packages.tensorflow-build_2): log was empty
  • python39Packages.ortools: log https://termbin.com/4mx3
  • rippled: log https://termbin.com/u7bj
  • rippled-validator-keys-tool: log was empty
21 packages built:
  • abseil-cpp
  • bear
  • grpc
  • linuxPackages.sysdig (linuxPackages_5_4.sysdig)
  • linuxPackages_4_14.sysdig
  • linuxPackages_4_19.sysdig
  • linuxPackages_5_10.sysdig (linuxPackages_latest.sysdig)
  • linuxPackages_5_9.sysdig
  • linuxPackages_hardened.sysdig
  • linuxPackages_latest-libre.sysdig
  • linuxPackages_latest_hardened.sysdig
  • linuxPackages_latest_xen_dom0.sysdig
  • linuxPackages_latest_xen_dom0_hardened.sysdig
  • linuxPackages_lqx.sysdig
  • linuxPackages_testing_bcachefs.sysdig
  • linuxPackages_xen_dom0.sysdig
  • linuxPackages_xen_dom0_hardened.sysdig
  • linuxPackages_zen.sysdig
  • murmur
  • qv2ray
  • sysdig

This was referenced Jan 18, 2021
Merged
Closed
@andersk andersk mentioned this pull request Jan 21, 2021
Closed
@acairncross acairncross mentioned this pull request Feb 20, 2021
Closed
10 tasks
@marsam
Copy link
Contributor

marsam commented Feb 23, 2021

addressed by #112951

@marsam marsam closed this Feb 23, 2021
@freezeboy freezeboy deleted the update-abseil-cpp branch February 23, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersk andersk Awaiting requested review from andersk

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@freezeboy @andersk @SuperSandro2000 @marsam